Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1859593002: [Cronet] Change cr_cronet.py to use stack wrapper in third_party (Closed)

Created:
4 years, 8 months ago by xunjieli
Modified:
4 years, 8 months ago
Reviewers:
pauljensen, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Change cr_cronet.py to use stack wrapper in third_party BUG=597343 Committed: https://crrev.com/3df67ed03b1649c528f4e5be73f2b6f53b10c6e0 Cr-Commit-Position: refs/heads/master@{#386104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M components/cronet/tools/cr_cronet.py View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
xunjieli
4 years, 8 months ago (2016-04-04 15:50:41 UTC) #2
pauljensen
I've never used either stack trace tool, nor have I used "cr_cronet.py stack", so I'll ...
4 years, 8 months ago (2016-04-04 17:14:21 UTC) #3
mef
On 2016/04/04 17:14:21, pauljensen wrote: > I've never used either stack trace tool, nor have ...
4 years, 8 months ago (2016-04-08 16:18:47 UTC) #4
xunjieli
On 2016/04/08 16:18:47, mef wrote: > On 2016/04/04 17:14:21, pauljensen wrote: > > I've never ...
4 years, 8 months ago (2016-04-08 16:27:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859593002/1
4 years, 8 months ago (2016-04-08 16:27:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 17:02:54 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 17:04:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3df67ed03b1649c528f4e5be73f2b6f53b10c6e0
Cr-Commit-Position: refs/heads/master@{#386104}

Powered by Google App Engine
This is Rietveld 408576698