Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1859513002: Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (Closed)

Created:
4 years, 8 months ago by Takashi Toyoshima
Modified:
4 years, 8 months ago
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (patchset #4 id:60001 of https://codereview.chromium.org/1840163002/ ) Reason for revert: Caused performance regression. Original issue's description: > Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. > > BUG=596760 > > Committed: https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c > Cr-Commit-Position: refs/heads/master@{#384213} TBR=haraken@chromium.org,yutak@chromium.org,kotenkov@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=596760, 599867 Committed: https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7 Cr-Commit-Position: refs/heads/master@{#384889}

Patch Set 1 #

Patch Set 2 : [rebase: remove BitArray.h diff] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -84 lines) Patch
M third_party/WebKit/Source/wtf/ArrayBuffer.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/Deque.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Optional.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/PageAllocator.cpp View 1 7 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/wtf/PartitionAlloc.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/PartitionAlloc.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/PartitionAllocator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Partitions.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/TypedArrayBase.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 1 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/wtf/WTF.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/CString.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringConcatenate.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringConcatenate.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 14 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Takashi Toyoshima
Created Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.
4 years, 8 months ago (2016-04-04 10:40:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859513002/1
4 years, 8 months ago (2016-04-04 10:40:51 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/13217) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-04 10:43:02 UTC) #5
Takashi Toyoshima
yep, BitArray.h was removed after this change. I'll make a rebased patch.
4 years, 8 months ago (2016-04-04 10:45:15 UTC) #6
haraken
LGTM to revert.
4 years, 8 months ago (2016-04-04 10:50:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859513002/290001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859513002/290001
4 years, 8 months ago (2016-04-04 11:02:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:290001)
4 years, 8 months ago (2016-04-04 12:26:00 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 12:27:53 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7
Cr-Commit-Position: refs/heads/master@{#384889}

Powered by Google App Engine
This is Rietveld 408576698