Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: pkg/analyzer/lib/src/summary/idl.dart

Issue 1859493002: Replace 'length' with more generic 'extractProperty' operation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/idl.dart
diff --git a/pkg/analyzer/lib/src/summary/idl.dart b/pkg/analyzer/lib/src/summary/idl.dart
index 31acca948e4f640e984fd859e18a2e7a10f50d52..caa835ff3fd768a5e7312dc56fd7fc433c20b669 100644
--- a/pkg/analyzer/lib/src/summary/idl.dart
+++ b/pkg/analyzer/lib/src/summary/idl.dart
@@ -718,11 +718,6 @@ enum ReferenceKind {
method,
/**
- * The `length` property access.
- */
- length,
-
- /**
* The entity is a typedef.
*/
typedef,
@@ -1129,6 +1124,13 @@ enum UnlinkedConstOperation {
pushReference,
/**
+ * Pop the top value from the stack, extract the value of the property with
+ * the name obtained from [UnlinkedConst.strings], and push the result back
+ * onto the stack.
+ */
+ extractProperty,
+
+ /**
* Pop the top `n` values from the stack (where `n` is obtained from
* [UnlinkedConst.ints]) into a list (filled from the end) and take the next
* `n` values from [UnlinkedConst.strings] and use the lists of names and
@@ -1322,12 +1324,6 @@ enum UnlinkedConstOperation {
* result back onto the stack.
*/
conditional,
-
- /**
- * Pop the top value from the stack, evaluate `v.length`, and push the result
- * back onto the stack.
- */
- length,
}
/**

Powered by Google App Engine
This is Rietveld 408576698