Replace 'length' with more generic 'extractProperty' operation.

pkg/analyzer/test/src/summary/resynthesize_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.serialization.elements_test;
 
 import 'dart:convert';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/constant/value.dart';
@@ skipping 462 matching lines @@
         // We don't resynthesize prefixed identifiers when the prefix refers to
         // a PrefixElement or a ClassElement.  We use simple identifiers with
         // correct elements.
         if (o.prefix.staticElement is PrefixElement ||
             o.prefix.staticElement is ClassElement) {
           compareConstAsts(r, o.identifier, desc);
         } else {
           fail('Prefix of type ${o.prefix.staticElement.runtimeType} should not'
               ' have been elided');
         }
+      } else if (o is SimpleIdentifier && r is PrefixedIdentifier) {
+        // In 'class C {static const a = 0; static const b = a;}' the reference
+        // to 'a' in 'b' is serialized as a fully qualified 'C.a' reference.
+        if (r.prefix.staticElement is ClassElement) {
+          compareConstAsts(r.identifier, o, desc);

[Paul Berry, 2016/04/04 15:51:25]

Please add a check to verify that r.prefix.staticElement points to the correct
class.

+        } else {
+          fail('Prefix of type ${r.prefix.staticElement.runtimeType} should not'
+              ' have been elided');
+        }
       } else if (o is PropertyAccess &&
           o.target is PrefixedIdentifier &&
           r is PrefixedIdentifier) {
         // We don't resynthesize prefixed identifiers when the prefix refers to
         // a PrefixElement or a ClassElement.  Which means that if the original
         // expression was e.g. `prefix.topLevelVariableName.length`, it will get
         // resynthesized as `topLevelVariableName.length`
         PrefixedIdentifier oTarget = o.target;
         checkElidablePrefix(oTarget.prefix);
         compareConstAsts(
@@ skipping 3735 matching lines @@
       fail('Unexpectedly tried to get unlinked summary for $uri');
     }
     return serializedUnit;
   }
 
   @override
   bool hasLibrarySummary(String uri) {
     return true;
   }
 }