Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: components/autofill/content/renderer/password_generation_agent.cc

Issue 1859453002: components/autofill: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on password_manager changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_generation_agent.cc
diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc
index a10878432403d515550511b1bbb49073dd9c4d76..51afb87b46d03b0f96ddfb2cb0ad5fdbe1c811fc 100644
--- a/components/autofill/content/renderer/password_generation_agent.cc
+++ b/components/autofill/content/renderer/password_generation_agent.cc
@@ -4,9 +4,10 @@
#include "components/autofill/content/renderer/password_generation_agent.h"
+#include <memory>
Mathieu 2016/04/04 13:36:17 and here too, in most other cc files it's omitted
vabr (Chromium) 2016/04/04 14:29:04 Here, on the other hand, line 207, for example, se
+
#include "base/command_line.h"
#include "base/logging.h"
-#include "base/memory/scoped_ptr.h"
#include "components/autofill/content/common/autofill_messages.h"
#include "components/autofill/content/renderer/form_autofill_util.h"
#include "components/autofill/content/renderer/password_autofill_agent.h"
@@ -203,7 +204,7 @@ void PasswordGenerationAgent::FindPossibleGenerationForm() {
// If we can't get a valid PasswordForm, we skip this form because the
// the password won't get saved even if we generate it.
- scoped_ptr<PasswordForm> password_form(
+ std::unique_ptr<PasswordForm> password_form(
CreatePasswordFormFromWebForm(forms[i], nullptr, nullptr));
if (!password_form.get()) {
VLOG(2) << "Skipping form as it would not be saved";
@@ -475,7 +476,7 @@ void PasswordGenerationAgent::OnUserTriggeredGeneratePassword() {
return;
blink::WebFormElement form = element->form();
- scoped_ptr<PasswordForm> password_form;
+ std::unique_ptr<PasswordForm> password_form;
std::vector<blink::WebFormControlElement> control_elements;
if (!form.isNull()) {
password_form = CreatePasswordFormFromWebForm(form, nullptr, nullptr);

Powered by Google App Engine
This is Rietveld 408576698