Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 1859453002: components/autofill: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on password_manager changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_form_conversion_utils.cc
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc
index afecbcbac0a5ffec7471cc22e55d4ff0344317e9..fa4f3fcef3f28310e75dfa78359000758c034f66 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.cc
+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc
@@ -7,12 +7,12 @@
#include <stddef.h>
#include <algorithm>
+#include <memory>
Mathieu 2016/04/04 13:36:16 same comment as for password_autofill_agent.cc
vabr (Chromium) 2016/04/04 14:29:04 Here it all derives from the header, so I agree to
#include <string>
#include "base/i18n/case_conversion.h"
#include "base/lazy_instance.h"
#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -633,17 +633,17 @@ bool IsGaiaReauthenticationForm(
return has_rart_field && has_continue_field;
}
-scoped_ptr<PasswordForm> CreatePasswordFormFromWebForm(
+std::unique_ptr<PasswordForm> CreatePasswordFormFromWebForm(
const WebFormElement& web_form,
const ModifiedValues* nonscript_modified_values,
const FormsPredictionsMap* form_predictions) {
if (web_form.isNull())
- return scoped_ptr<PasswordForm>();
+ return std::unique_ptr<PasswordForm>();
- scoped_ptr<PasswordForm> password_form(new PasswordForm());
+ std::unique_ptr<PasswordForm> password_form(new PasswordForm());
password_form->action = form_util::GetCanonicalActionForForm(web_form);
if (!password_form->action.is_valid())
- return scoped_ptr<PasswordForm>();
+ return std::unique_ptr<PasswordForm>();
SyntheticForm synthetic_form;
PopulateSyntheticFormFromWebForm(web_form, &synthetic_form);
@@ -654,12 +654,12 @@ scoped_ptr<PasswordForm> CreatePasswordFormFromWebForm(
if (!GetPasswordForm(synthetic_form, password_form.get(),
nonscript_modified_values, form_predictions))
- return scoped_ptr<PasswordForm>();
+ return std::unique_ptr<PasswordForm>();
return password_form;
}
-scoped_ptr<PasswordForm> CreatePasswordFormFromUnownedInputElements(
+std::unique_ptr<PasswordForm> CreatePasswordFormFromUnownedInputElements(
const WebFrame& frame,
const ModifiedValues* nonscript_modified_values,
const FormsPredictionsMap* form_predictions) {
@@ -669,16 +669,16 @@ scoped_ptr<PasswordForm> CreatePasswordFormFromUnownedInputElements(
synthetic_form.document = frame.document();
if (synthetic_form.control_elements.empty())
- return scoped_ptr<PasswordForm>();
+ return std::unique_ptr<PasswordForm>();
- scoped_ptr<PasswordForm> password_form(new PasswordForm());
+ std::unique_ptr<PasswordForm> password_form(new PasswordForm());
UnownedPasswordFormElementsAndFieldSetsToFormData(
synthetic_form.fieldsets, synthetic_form.control_elements, nullptr,
frame.document(), form_util::EXTRACT_NONE, &password_form->form_data,
nullptr /* FormFieldData */);
if (!GetPasswordForm(synthetic_form, password_form.get(),
nonscript_modified_values, form_predictions))
- return scoped_ptr<PasswordForm>();
+ return std::unique_ptr<PasswordForm>();
// No actual action on the form, so use the the origin as the action.
password_form->action = password_form->origin;

Powered by Google App Engine
This is Rietveld 408576698