Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: components/autofill/content/browser/risk/fingerprint_browsertest.cc

Issue 1859453002: components/autofill: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on password_manager changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/risk/fingerprint_browsertest.cc
diff --git a/components/autofill/content/browser/risk/fingerprint_browsertest.cc b/components/autofill/content/browser/risk/fingerprint_browsertest.cc
index 25179808fa6f4933c86726122282e6a855ab20cf..bbbc5f6c8fd8db8c3ed47417585fed76ce0daca5 100644
--- a/components/autofill/content/browser/risk/fingerprint_browsertest.cc
+++ b/components/autofill/content/browser/risk/fingerprint_browsertest.cc
@@ -41,7 +41,7 @@ void GetFingerprintInternal(
const std::string& app_locale,
const std::string& user_agent,
const base::TimeDelta& timeout,
- const base::Callback<void(scoped_ptr<Fingerprint>)>& callback);
+ const base::Callback<void(std::unique_ptr<Fingerprint>)>& callback);
Mathieu 2016/04/04 13:36:16 Is it a pattern not to include <memory> for tests?
vabr (Chromium) 2016/04/04 14:29:04 I believe this is a good place to have the #includ
} // namespace internal
@@ -71,7 +71,7 @@ class AutofillRiskFingerprintTest : public content::ContentBrowserTest {
available_screen_bounds_(0, 11, 101, 60),
unavailable_screen_bounds_(0, 0, 101, 11) {}
- void GetFingerprintTestCallback(scoped_ptr<Fingerprint> fingerprint) {
+ void GetFingerprintTestCallback(std::unique_ptr<Fingerprint> fingerprint) {
// Verify that all fields Chrome can fill have been filled.
ASSERT_TRUE(fingerprint->has_machine_characteristics());
const Fingerprint::MachineCharacteristics& machine =

Powered by Google App Engine
This is Rietveld 408576698