components/autofill/core/browser/webdata/autofill_profile_syncable_service.h - Issue 1859453002: components/autofill: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

Issue 1859453002: components/autofill: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/autofill_data_type_controller_unittest.cc ('k') | components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

diff --git a/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h b/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

index f67f661371ddd578fabe79e8030d14f478c11551..78c08726ea07fc1941bf29b7f50fd674b121bad5 100644

--- a/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

+++ b/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

@@ -5,6 +5,7 @@

#define COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOFILL_PROFILE_SYNCABLE_SERVICE_H_

#include <map>

+#include <memory>

#include <string>

#include <vector>

@@ -69,8 +70,8 @@ class AutofillProfileSyncableService

syncer::SyncMergeResult MergeDataAndStartSyncing(

syncer::ModelType type,

const syncer::SyncDataList& initial_sync_data,

- scoped_ptr<syncer::SyncChangeProcessor> sync_processor,

- scoped_ptr<syncer::SyncErrorFactory> sync_error_factory) override;

+ std::unique_ptr<syncer::SyncChangeProcessor> sync_processor,

+ std::unique_ptr<syncer::SyncErrorFactory> sync_error_factory) override;

void StopSyncing(syncer::ModelType type) override;

syncer::SyncDataList GetAllSyncData(syncer::ModelType type) const override;

syncer::SyncError ProcessSyncChanges(

@@ -180,9 +181,9 @@ class AutofillProfileSyncableService

ScopedVector<AutofillProfile> profiles_;

GUIDToProfileMap profiles_map_;

- scoped_ptr<syncer::SyncChangeProcessor> sync_processor_;

+ std::unique_ptr<syncer::SyncChangeProcessor> sync_processor_;

- scoped_ptr<syncer::SyncErrorFactory> sync_error_factory_;

+ std::unique_ptr<syncer::SyncErrorFactory> sync_error_factory_;

syncer::SyncableService::StartSyncFlare flare_;