components/autofill/core/browser/phone_number_i18n.cc - Issue 1859453002: components/autofill: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/phone_number_i18n.cc

Issue 1859453002: components/autofill: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/phone_number_i18n.cc

diff --git a/components/autofill/core/browser/phone_number_i18n.cc b/components/autofill/core/browser/phone_number_i18n.cc

index 6c90e6b78c7ffc5f2ee9602d154ffb7709aba38f..66fe9faac5675b931928fb87baa6928ab88f03ed 100644

--- a/components/autofill/core/browser/phone_number_i18n.cc

+++ b/components/autofill/core/browser/phone_number_i18n.cc

@@ -246,7 +246,7 @@ PhoneObject::PhoneObject(const base::string16& number,

// [ http://crbug.com/100845 ]. Once the bug is fixed, add a DCHECK here to

// verify.

- scoped_ptr<PhoneNumber> i18n_number(new PhoneNumber);

+ std::unique_ptr<PhoneNumber> i18n_number(new PhoneNumber);

if (ParsePhoneNumber(number, region, &country_code_, &city_code_, &number_,

&region_, i18n_number.get())) {

// The phone number was successfully parsed, so store the parsed version.