LayoutTests/http/tests/inspector/network/network-sidebar-width.html - Issue 185943004: DevTools: Do not save split view size on show mode changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/inspector/network/network-sidebar-width.html

Issue 185943004: DevTools: Do not save split view size on show mode changes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Comments addressed Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
	(Empty)
1 <html>

2 <head>

3 <script src="../inspector-test.js"></script>

4 <script src="../network-test.js"></script>

5 <script>

6 function test()

7 {

8 InspectorTest.recordNetwork();

9 InspectorTest.makeSimpleXHR("GET", "resources/resource.php", true, step2);

10

11 var oldSetting;

12 function step2()

13 {

14 var panel = WebInspector.panel("network");

15 var settingName = "networkPanelSplitViewState";

16 var setting = WebInspector.settings.createSetting(settingName, undefined );

17 WebInspector.settings[settingName] = setting;

18 var request = WebInspector.panel("network").requests[WebInspector.panel( "network").requests.length - 1];

19

20 settingValue = setting.get();

21 settingValue.vertical = settingValue.vertical \|\| {};

22 var oldSize = settingValue.vertical.size;

23 WebInspector.inspectorView.showPanel("network");

24

25 delete settingValue.vertical.size;

26 setting.set(settingValue);

27 panel._showRequest(request);

28 InspectorTest.addResult("Sidebar width: " + panel._splitView.sidebarElem ent().offsetWidth);

29 panel._toggleGridMode();

30

31 settingValue.vertical.size = 242;

32 setting.set(settingValue);

33 panel._showRequest(request);

34 InspectorTest.addResult("Sidebar width: " + panel._splitView.sidebarElem ent().offsetWidth);

35 panel._closeVisibleRequest(request);

36

37 settingValue.vertical.size = oldSize;

38 setting.set(settingValue);

39

40 InspectorTest.completeTest();

41 }

42 }

43 </script>

44 </head>

45 <body onload="runTest()">

46 <p>Tests network panel sidebar width with and without preference set.</p>

47 <a href="https://bugs.webkit.org/show_bug.cgi?id=65256">Bug 65256</a>

48 </body>

49 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/inspector/network/network-sidebar-width-expected.txt » ('j') | Source/devtools/front_end/SplitView.js » ('J')