Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Side by Side Diff: LayoutTests/inspector/split-view.html

Issue 185943004: DevTools: Do not save split view size on show mode changes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 <html>
2 <head>
3 <script src="../http/tests/inspector/inspector-test.js"></script>
4 <script>
5
6 function test()
7 {
8 var settingIndex = 0;
9 function createAndShowSplitView(isVertical, secondIsSidebar, settingName, de faultSidebarWidth, defaultSidebarHeight, useDip, shouldSaveShowMode)
10 {
11 var splitView = new WebInspector.SplitView(isVertical, secondIsSidebar, settingName, defaultSidebarWidth, defaultSidebarHeight, useDip);
12 if (shouldSaveShowMode)
13 splitView.enableShowModeSaving();
14 splitView.element.style.position = "absolute";
15 splitView.element.style.top = "0";
16 splitView.element.style.left = "0";
17 splitView.element.style.height = "500px";
18 splitView.element.style.width = "500px";
19 splitView.markAsRoot();
20 splitView.show(document.body);
21 return splitView;
22 }
23
24 function dumpSplitViewOrientationShowModeAndSidebarSize(splitView)
25 {
26 var sidebarSize = splitView.isVertical() ? splitView.sidebarElement().of fsetWidth : splitView.sidebarElement().offsetHeight;
27 var orientation = splitView.isVertical() ? "vertical" : "horizontal";
28 InspectorTest.addResult(" Sidebar size = " + sidebarSize + ", showMod e = " + splitView.showMode() + ", " + orientation);
29 InspectorTest.addResult(" Setting value: " + localStorage[splitView._ settingName]);
30 }
31
32 function testSplitViewSizes(useFraction, shouldSaveShowMode)
33 {
34 var secondIsSidebar = true;
35 var settingName = "splitViewStateSettingName" + (++settingIndex);
36 var defaultSidebarWidth = useFraction ? 0.23 : 101;
37 var defaultSidebarHeight = useFraction ? 0.24 : 102;
38 var newWidth = useFraction ? 125 : 201;
39 var newHeight = useFraction ? 130 : 202;
40
41 var splitView;
42 InspectorTest.addResult("Create default split view");
43 var params = "useFraction = " + useFraction + ", shouldSaveShowMode = " + shouldSaveShowMode;
44 InspectorTest.addResult("Running split view test with the following para meters: " + params);
45
46 InspectorTest.addResult("Creating split view");
47 splitView = createAndShowSplitView(true, secondIsSidebar, settingName, d efaultSidebarWidth, defaultSidebarHeight, false, shouldSaveShowMode);
48 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
49
50 InspectorTest.addResult("Hiding sidebar");
51 splitView.hideSidebar();
52 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
53
54 InspectorTest.addResult("Showing sidebar");
55 splitView.showBoth();
56 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
57
58 InspectorTest.addResult("Resizing");
59 splitView.setSidebarSize(newWidth);
60 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
61
62 InspectorTest.addResult("Hiding sidebar");
63 splitView.hideSidebar();
64 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
65
66 InspectorTest.addResult("Showing sidebar");
67 splitView.showBoth();
68 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
69
70 InspectorTest.addResult("Making horizontal");
71 splitView.setVertical(false);
72 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
73
74 InspectorTest.addResult("Resizing");
75 splitView.setSidebarSize(newHeight);
76 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
77
78 InspectorTest.addResult("Hiding sidebar");
79 splitView.hideSidebar();
80 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
81
82 splitView.element.remove();
83
84 InspectorTest.addResult("Recreating split view");
85 splitView = createAndShowSplitView(true, secondIsSidebar, settingName, d efaultSidebarWidth, defaultSidebarHeight, false, shouldSaveShowMode);
86 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
87
88 InspectorTest.addResult("Hiding sidebar");
89 splitView.hideSidebar();
90 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
91
92 InspectorTest.addResult("Making horizontal");
93 splitView.setVertical(false);
94 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
95
96 InspectorTest.addResult("Showing sidebar");
97 splitView.showBoth();
98 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
99
100 splitView.element.remove();
101
102 InspectorTest.addResult("Recreating split view");
103 splitView = createAndShowSplitView(true, secondIsSidebar, settingName, d efaultSidebarWidth, defaultSidebarHeight, false, shouldSaveShowMode);
104 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
105
106 InspectorTest.addResult("Making horizontal");
107 splitView.setVertical(false);
108 dumpSplitViewOrientationShowModeAndSidebarSize(splitView);
109
110 splitView.element.remove();
111 InspectorTest.addResult("");
112 }
113
114 // Test all combinations of useFraction and shouldSaveShowMode flags
115 testSplitViewSizes(false, false);
116 testSplitViewSizes(false, true);
117 testSplitViewSizes(true, false);
118 testSplitViewSizes(true, true);
119 InspectorTest.completeTest();
120 }
121 </script>
122 </head>
123 <body onload="runTest()">
124 <p>Tests how split view saving to settings works.</p>
125 </body>
126 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698