Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: tools/buildbot_spec.py

Issue 1859413003: Add XSAN suppression files to infrabots.isolate. (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Fix buildbot_spec.py for builders without extra-config. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « infra/bots/infrabots.isolate ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # 1 #
2 # Copyright 2015 Google Inc. 2 # Copyright 2015 Google Inc.
3 # 3 #
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 # 6 #
7 7
8 #!/usr/bin/env python 8 #!/usr/bin/env python
9 9
10 usage = ''' 10 usage = '''
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 return env 192 return env
193 193
194 194
195 cov_skip.extend([lineno(), lineno() + 1]) 195 cov_skip.extend([lineno(), lineno() + 1])
196 def build_targets_from_builder_dict(builder_dict, do_test_steps, do_perf_steps): 196 def build_targets_from_builder_dict(builder_dict, do_test_steps, do_perf_steps):
197 """Return a list of targets to build, depending on the builder type.""" 197 """Return a list of targets to build, depending on the builder type."""
198 if builder_dict['role'] in ('Test', 'Perf') and builder_dict['os'] == 'iOS': 198 if builder_dict['role'] in ('Test', 'Perf') and builder_dict['os'] == 'iOS':
199 return ['iOSShell'] 199 return ['iOSShell']
200 if builder_dict.get('extra_config') == 'Appurify': 200 if builder_dict.get('extra_config') == 'Appurify':
201 return ['VisualBenchTest_APK'] 201 return ['VisualBenchTest_APK']
202 if 'SAN' in builder_dict.get('extra_config', ''):
203 # 'most' does not compile under MSAN.
204 return ['dm', 'nanobench']
202 t = [] 205 t = []
203 if do_test_steps: 206 if do_test_steps:
204 t.append('dm') 207 t.append('dm')
205 if do_perf_steps and builder_dict.get('extra_config') == 'VisualBench': 208 if do_perf_steps and builder_dict.get('extra_config') == 'VisualBench':
206 t.append('visualbench') 209 t.append('visualbench')
207 elif do_perf_steps: 210 elif do_perf_steps:
208 t.append('nanobench') 211 t.append('nanobench')
209 if t: 212 if t:
210 return t 213 return t
211 else: 214 else:
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 if len(sys.argv) == 2 and sys.argv[1] == 'test': 401 if len(sys.argv) == 2 and sys.argv[1] == 'test':
399 self_test() 402 self_test()
400 sys.exit(0) 403 sys.exit(0)
401 404
402 if len(sys.argv) != 3: 405 if len(sys.argv) != 3:
403 print usage 406 print usage
404 sys.exit(1) 407 sys.exit(1)
405 408
406 with open(sys.argv[1], 'w') as out: 409 with open(sys.argv[1], 'w') as out:
407 json.dump(get_builder_spec(sys.argv[2]), out) 410 json.dump(get_builder_spec(sys.argv[2]), out)
OLDNEW
« no previous file with comments | « infra/bots/infrabots.isolate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698