Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1859393002: chrome://supervised-user-internals: handle null AccountTrackerService (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@policy_bleh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome://supervised-user-internals: handle null AccountTrackerService This fixes a crash when the page is accessed in guest or incognito mode. BUG=600236 Committed: https://crrev.com/89f1e2e60059c782353b26fd2f9c7eb00a133810 Cr-Commit-Position: refs/heads/master@{#385449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M chrome/browser/ui/webui/supervised_user_internals_message_handler.cc View 1 chunk +14 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859393002/1
4 years, 8 months ago (2016-04-06 11:16:36 UTC) #2
Marc Treib
PTAL!
4 years, 8 months ago (2016-04-06 11:16:46 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 12:55:29 UTC) #6
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-04-06 13:40:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859393002/1
4 years, 8 months ago (2016-04-06 13:42:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 13:47:07 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 13:48:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89f1e2e60059c782353b26fd2f9c7eb00a133810
Cr-Commit-Position: refs/heads/master@{#385449}

Powered by Google App Engine
This is Rietveld 408576698