Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1859363005:
Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS (Closed)
|
Created:
4 years, 8 months ago by magjed_chromium Modified:
4 years, 8 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable flaky FeedbackTest.ShowLoginFeedback on Chrome OS
BUG=601306
TBR=rkc
NOTRY=true
Committed: https://crrev.com/eac516a0acc5863cb988937194d645928cc4871a
Cr-Commit-Position: refs/heads/master@{#385748}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS BUG=601306 ========== to ========== Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS BUG=601306 ==========
magjed@chromium.org changed reviewers: + beaudoin@chromium.org
Description was changed from ========== Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS BUG=601306 ========== to ========== Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS BUG=601306 NOTRY=true ==========
Please take a look.
The CQ bit was checked by magjed@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859363005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859363005/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS BUG=601306 NOTRY=true ========== to ========== Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS BUG=601306 TBR=rkc NOTRY=true ==========
magjed@chromium.org changed reviewers: + rkc@chromium.org
The CQ bit was checked by magjed@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859363005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859363005/1
Message was sent while issue was closed.
Description was changed from ========== Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS BUG=601306 TBR=rkc NOTRY=true ========== to ========== Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS BUG=601306 TBR=rkc NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS BUG=601306 TBR=rkc NOTRY=true ========== to ========== Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS BUG=601306 TBR=rkc NOTRY=true Committed: https://crrev.com/eac516a0acc5863cb988937194d645928cc4871a Cr-Commit-Position: refs/heads/master@{#385748} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/eac516a0acc5863cb988937194d645928cc4871a Cr-Commit-Position: refs/heads/master@{#385748}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1869143003/ by miu@chromium.org. The reason for reverting is: Fixed by: https://codereview.chromium.org/1871663002/. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
