Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1859363003: allow --dart-sdk with --persisent_worker (Closed)

Created:
4 years, 8 months ago by jakemac
Modified:
4 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 1 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jakemac
4 years, 8 months ago (2016-04-06 22:12:07 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/1859363003/diff/1/pkg/analyzer_cli/lib/src/options.dart File pkg/analyzer_cli/lib/src/options.dart (right): https://codereview.chromium.org/1859363003/diff/1/pkg/analyzer_cli/lib/src/options.dart#newcode468 pkg/analyzer_cli/lib/src/options.dart:468: var validArgs; IIRC, strong mode won't infer a ...
4 years, 8 months ago (2016-04-07 02:40:21 UTC) #3
jakemac
https://codereview.chromium.org/1859363003/diff/1/pkg/analyzer_cli/lib/src/options.dart File pkg/analyzer_cli/lib/src/options.dart (right): https://codereview.chromium.org/1859363003/diff/1/pkg/analyzer_cli/lib/src/options.dart#newcode468 pkg/analyzer_cli/lib/src/options.dart:468: var validArgs; On 2016/04/07 02:40:20, Paul Berry wrote: > ...
4 years, 8 months ago (2016-04-07 14:02:17 UTC) #4
jakemac
4 years, 8 months ago (2016-04-07 14:09:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
63efb288a7ebed27c1a79a97cf4ec8ff6e0e8147 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698