third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-to-http-iframe.html - Issue 1859343002: ServiceWorker: Remove iframes explicitly after a test is finished

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-to-http-iframe.html

Issue 1859343002: ServiceWorker: Remove iframes explicitly after a test is finished (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove a comment line Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/postmessage-msgport-to-client.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/test-helpers.js » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/test-helpers.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-to-http-iframe.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-to-http-iframe.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-to-http-iframe.html

index 52b50421eed083f5c85aa6f466e27c150a9844e2..17ba0deecc0871b2d529aa11706e4259645a7ced 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-to-http-iframe.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-to-http-iframe.html

@@ -32,7 +32,7 @@ navigator.serviceWorker.getRegistration(SCOPE)

function on_state_change(event) {

if (event.target.state != 'activated')

return;

- with_iframe(SCOPE)

+ with_iframe(SCOPE, IFRAME_RECLAMATION.FALSE)

.then(function(frame) {

window.parent.postMessage(

{results: frame.contentDocument.body.textContent},