Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/unregister-then-register.html

Issue 1859343002: ServiceWorker: Remove iframes explicitly after a test is finished (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/unregister-then-register.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/unregister-then-register.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/unregister-then-register.html
index cec2ddc85410777c300e6c0b14e1fdf958173378..17eeb91609c0120cfe764cdfa7d3e048de2fd49d 100644
--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/unregister-then-register.html
+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/unregister-then-register.html
@@ -39,7 +39,7 @@ async_test(function(t) {
return wait_for_state(t, r.installing, 'activated');
})
.then(function() {
- return with_iframe(scope);
+ return with_iframe(scope, true);
})
.then(function(frame) {
return registration.unregister();
@@ -68,7 +68,7 @@ async_test(function(t) {
return wait_for_state(t, r.installing, 'activated');
})
.then(function() {
- return with_iframe(scope);
+ return with_iframe(scope, true);
})
.then(function(frame) {
iframe = frame;
@@ -102,7 +102,7 @@ async_test(function(t) {
return wait_for_state(t, r.installing, 'activated');
})
.then(function() {
- return with_iframe(scope);
+ return with_iframe(scope, true);
})
.then(function(frame) {
iframe = frame;
@@ -113,7 +113,7 @@ async_test(function(t) {
})
.then(function() {
iframe.remove();
- return with_iframe(scope);
+ return with_iframe(scope, true);
})
.then(function(frame) {
// FIXME: When crbug.com/400602 is fixed, assert that controller

Powered by Google App Engine
This is Rietveld 408576698