ServiceWorker: Remove iframes explicitly after a test is finished

third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/test-helpers.js

 // Adapter for testharness.js-style tests with Service Workers
 
 function service_worker_unregister_and_register(test, url, scope) {
   if (!scope || scope.length == 0)
     return Promise.reject(new Error('tests must define a scope'));
 
   var options = { scope: scope };
   return service_worker_unregister(test, scope)
     .then(function() {
         return navigator.serviceWorker.register(url, options);
@@ skipping 26 matching lines @@
 // Rejection-specific helper that provides more details
 function unreached_rejection(test, prefix) {
   return test.step_func(function(error) {
       var reason = error.message || error.name || error;
       var error_prefix = prefix || 'unexpected rejection';
       assert_unreached(error_prefix + ': ' + reason);
     });
 }
 
 // Adds an iframe to the document and returns a promise that resolves to the
-// iframe when it finishes loading. The caller is responsible for removing the
-// iframe later if needed.
-function with_iframe(url) {
+// iframe when it finishes loading. By default, the caller is responsible for

[nhiroki, 2016/04/06 07:46:35]

"By default" sounds a bit unclear. Can you elaborate the meaning of
|reclaim_after_completion|? For example,

// iframe when it finishes loading. If |reclaim_after_completion| is true,
registers a completion callback to remove the frame. Otherwise, the caller is
responsible for removing the iframe later.

[falken, 2016/04/06 07:49:05]

Drive-by comment: How about making reclaim_after_completion the default
behavior? Also I'd slightly prefer passing some const value instead of
true/false for readability.

[shimazu (google), 2016/04/07 04:17:59]

Done.

+// removing the iframe later if needed.
+function with_iframe(url, reclaim_after_completion) {
   return new Promise(function(resolve) {
       var frame = document.createElement('iframe');
       frame.src = url;
       frame.onload = function() { resolve(frame); };
       document.body.appendChild(frame);
+      if (reclaim_after_completion)

[nhiroki, 2016/04/06 07:46:35]

if (reclaim_after_compleation === true)

... could be more stable in JS.

[shimazu (google), 2016/04/07 04:17:59]

Done.

+        add_completion_callback(function() { frame.remove(); });
     });
 }
 
 function with_sandboxed_iframe(url, sandbox) {
   return new Promise(function(resolve) {
       var frame = document.createElement('iframe');
       frame.sandbox = sandbox;
       frame.src = url;
       frame.onload = function() { resolve(frame); };
       document.body.appendChild(frame);
@@ skipping 125 matching lines @@
 
 function login(test, local, remote) {
   var suffix = (local.indexOf("https") != -1) ? "s": "";
   return test_login(test, local, 'username1' + suffix, 'password1' + suffix,
                     'cookie1')
     .then(function() {
         return test_login(test, remote, 'username2' + suffix,
                           'password2' + suffix, 'cookie2');
       });
 }