Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 185933003: [GCM] Only allow the senders that the application is currently registered for (Closed)

Created:
6 years, 9 months ago by fgorski
Modified:
6 years, 9 months ago
Reviewers:
Dmitry Titov, jianli
CC:
chromium-reviews
Visibility:
Public.

Description

[GCM] Only allow the senders that the application is currently registered for Only allow the senders that the application is currently registered for to send messages to it. * GCMProfileService adds a check that the app is currently registered for the sender_id of the sender that sent the message * IncomingMessage is extended to add sender_id * GCMClientImpl adds the sender_id to the incoming message in the handling code. * Adding a test verifying that messages are not delivered when not registered for senders * fixing the GCM Profile Service tests that were previously not registering for senders before delivering messages * Also: moving the DCHECKS in the GCMClientImpl::HandleIncomingMessage higher up to run them as soon as the checks values are available. BUG=344665

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -6 lines) Patch
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 1 9 chunks +64 lines, -0 lines 0 comments Download
M google_apis/gcm/gcm_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fgorski
PTAL. This patch depends on https://codereview.chromium.org/183923006/ --- the single sender only change.
6 years, 9 months ago (2014-03-03 19:36:18 UTC) #1
Dmitry Titov
LGTM assuming the "single sender" goes first :-)
6 years, 9 months ago (2014-03-03 20:02:37 UTC) #2
jianli
Please re-upload the patch due to missing side-by-side differences.
6 years, 9 months ago (2014-03-04 01:14:54 UTC) #3
fgorski
6 years, 9 months ago (2014-03-05 00:32:19 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698