Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

Issue 1859313002: Save-Data should not be added to CORS Access-Control-Request-Headers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/test/embedded_test_server/http_request.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp
diff --git a/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp b/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp
index 672aebb6adf022d6309b0c385037d1fafb0a7101..61cc25d0184ce6528b22302e3d9392746fa787e2 100644
--- a/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp
+++ b/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp
@@ -94,6 +94,13 @@ ResourceRequest createAccessControlPreflightRequest(const ResourceRequest& reque
// Access-Control-Request-Headers header.
continue;
}
+ if (equalIgnoringCase(header.key, "save-data")) {
+ // As a short-term fix, exclude Save-Data from
+ // Access-Control-Request-Headers header.
+ // TODO(crbug.com/601092): Longer-term all simple headers should
kinuko 2016/04/07 01:12:28 TODO(name): crbug.com/601092 Longer-term all simpl
Raj 2016/04/07 01:18:14 Done.
+ // be excluded as well.
+ continue;
+ }
headers.append(header.key.lower());
}
std::sort(headers.begin(), headers.end(), WTF::codePointCompareLessThan);
« no previous file with comments | « net/test/embedded_test_server/http_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698