content/test/data/service_worker/fetch_cross_origin.html - Issue 1859313002: Save-Data should not be added to CORS Access-Control-Request-Headers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/service_worker/fetch_cross_origin.html

Issue 1859313002: Save-Data should not be added to CORS Access-Control-Request-Headers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/service_worker/service_worker_browsertest.cc ('K') | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/test/data/service_worker/fetch_event_pass_through.js » ('j') | content/test/data/service_worker/fetch_event_pass_through.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>INITIAL</title>

	5 <script>

	6 var queryString = location.search;

	7

	8 if (queryString && queryString.charAt(0) === '?') {

	9 // Fetches the URL provided in query string with a custom header.

	10 fetch(queryString.substring(1),

	11 {headers: {'X-Custom-Header': 'foo'}}).then(function(data) {

	12 data.text().then(function(text) {

	13 document.title = text;

	14 });
	falken 2016/04/06 04:41:36 nit: Service worker test code likes to chain promi nit: Service worker test code likes to chain promises when possible (and using arrow operator makes it less verbose): fetch(queryString.substring(1), {headers: {'X-Custom-Header': 'foo'}}) .then(data => data.text()) .then(text => document.title = text) .catch(() => document.title = 'FAIL'); Raj 2016/04/06 05:08:42 Done. Nice. Show quoted text On 2016/04/06 04:41:36, falken wrote: > nit: Service worker test code likes to chain promises when possible (and using > arrow operator makes it less verbose): > > fetch(queryString.substring(1), {headers: {'X-Custom-Header': 'foo'}}) > .then(data => data.text()) > .then(text => document.title = text) > .catch(() => document.title = 'FAIL'); Done. Nice.
	15 }).catch(function() {

	16 document.title = "FAIL";
	falken 2016/04/06 04:41:36 Use single-quotes for consistency. Use single-quotes for consistency. Raj 2016/04/06 05:08:42 Done. Show quoted text On 2016/04/06 04:41:36, falken wrote: > Use single-quotes for consistency. Done.
	17 });

	18 }

	19 </script>

	20 </head>

	21 </html>

OLD	NEW