Avoid restoring maximized window down when going fullscreen.

Avoid restoring maximized window down when going fullscreen.

This was causing the window to temporarily appear at its restored size.
Making HWNDMessageHandler::IsMaximized return false when fullscreened is
another way of achieving the same goal - ensuring the task bar is
hidden.

BUG=600678
TEST=fullscreen/unfullscreen windows with/without themes on Win 7 without aero, win7 with aero, and win10.

Committed: https://crrev.com/fab6a4eec6cb6b40e9931465bbc90d545a6d40ed
Cr-Commit-Position: refs/heads/master@{#386864}

[jbauman, 2016-04-07 02:13:38]

Description was changed from

==========
Avoid restoring maximize window down when going fullscreen.

This was causing the window to temporarily appear at its restored size.
Removing WS_MAXIMIZE from the window style seems to be an alternate way
of accomplishing the same purpose - ensuring the task bar is hidden.

BUG=600678
==========

to

==========
Avoid restoring maximized window down when going fullscreen.

This was causing the window to temporarily appear at its restored size.
Making HWNDMessageHandler::IsMaximized return false when fullscreened is
another way of achieving the same goal - ensuring the task bar is
hidden.

BUG=600678
TEST=fullscreen/unfullscreen windows with/without themes on Win 7 without aero,
win7 with aero, and win10.
==========

[jbauman, 2016-04-08 01:11:12]

jbauman@chromium.org changed reviewers:
+ ananta@chromium.org, sky@chromium.org

[sky, 2016-04-08 15:59:35]

How about test coverage?

[jbauman, 2016-04-12 00:50:29]

On 2016/04/08 15:59:35, sky wrote:
> How about test coverage?

PTAL. Added a test that the client area of the fullscreen window is correct
(that seems likely to have been the original cause of the taskbar problem).

[sky, 2016-04-12 13:34:03]

LGTM

https://codereview.chromium.org/1859283003/diff/40001/ui/views/widget/widget_...
File ui/views/widget/widget_interactive_uitest.cc (right):

https://codereview.chromium.org/1859283003/diff/40001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:838: ::GetMonitorInfo(monitor,
&monitor_info);
ASSERT on return value?

[jbauman, 2016-04-12 22:34:53]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-04-12 22:34:53]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1859283003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-12 22:35:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859283003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859283003/60001

[commit-bot: I haz the power, 2016-04-12 23:37:28]

Description was changed from

==========
Avoid restoring maximized window down when going fullscreen.

This was causing the window to temporarily appear at its restored size.
Making HWNDMessageHandler::IsMaximized return false when fullscreened is
another way of achieving the same goal - ensuring the task bar is
hidden.

BUG=600678
TEST=fullscreen/unfullscreen windows with/without themes on Win 7 without aero,
win7 with aero, and win10.
==========

to

==========
Avoid restoring maximized window down when going fullscreen.

This was causing the window to temporarily appear at its restored size.
Making HWNDMessageHandler::IsMaximized return false when fullscreened is
another way of achieving the same goal - ensuring the task bar is
hidden.

BUG=600678
TEST=fullscreen/unfullscreen windows with/without themes on Win 7 without aero,
win7 with aero, and win10.
==========

[commit-bot: I haz the power, 2016-04-12 23:37:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-12 23:38:40]

Description was changed from

==========
Avoid restoring maximized window down when going fullscreen.

This was causing the window to temporarily appear at its restored size.
Making HWNDMessageHandler::IsMaximized return false when fullscreened is
another way of achieving the same goal - ensuring the task bar is
hidden.

BUG=600678
TEST=fullscreen/unfullscreen windows with/without themes on Win 7 without aero,
win7 with aero, and win10.
==========

to

==========
Avoid restoring maximized window down when going fullscreen.

This was causing the window to temporarily appear at its restored size.
Making HWNDMessageHandler::IsMaximized return false when fullscreened is
another way of achieving the same goal - ensuring the task bar is
hidden.

BUG=600678
TEST=fullscreen/unfullscreen windows with/without themes on Win 7 without aero,
win7 with aero, and win10.

Committed: https://crrev.com/fab6a4eec6cb6b40e9931465bbc90d545a6d40ed
Cr-Commit-Position: refs/heads/master@{#386864}
==========

[commit-bot: I haz the power, 2016-04-12 23:38:44]

Patchset 4 (id:??) landed as
https://crrev.com/fab6a4eec6cb6b40e9931465bbc90d545a6d40ed
Cr-Commit-Position: refs/heads/master@{#386864}