Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 1859273002: Add flag to disable string externalization (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc
index 20ccd3a12e1351477b370adf1bda8004ef146b0b..b1d188aef4ef11ead3b9c9e24ebb12c2dbbde78f 100644
--- a/runtime/vm/flow_graph_type_propagator.cc
+++ b/runtime/vm/flow_graph_type_propagator.cc
@@ -270,7 +270,7 @@ void FlowGraphTypePropagator::VisitGuardFieldClass(
const intptr_t cid = guard->field().guarded_cid();
if ((cid == kIllegalCid) ||
(cid == kDynamicCid) ||
- !CheckClassInstr::IsImmutableClassId(cid)) {
+ Field::IsExternalizableCid(cid)) {
return;
}
@@ -782,7 +782,7 @@ CompileType ConstantInstr::ComputeType() const {
}
intptr_t cid = value().GetClassId();
- if (!CheckClassInstr::IsImmutableClassId(cid)) {
+ if (Field::IsExternalizableCid(cid)) {
cid = kDynamicCid;
}
@@ -965,7 +965,7 @@ CompileType LoadStaticFieldInstr::ComputeType() const {
cid = obj.GetClassId();
}
}
- if (!CheckClassInstr::IsImmutableClassId(cid)) {
+ if (Field::IsExternalizableCid(cid)) {
cid = kDynamicCid;
}
return CompileType(is_nullable, cid, abstract_type);
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698