Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 185923002: Rename test files to end with Test.cpp. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
rmistry, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Rename test files to end with Test.cpp. DM builds all of {bench,gm,test}/*.cpp. A Windows build warned us that we were trying to link typeface.obj twice. This must have something to do with there existing gm/typeface.cpp and tests/Typeface.cpp. To be safe, make sure tests have a Test.cpp suffix to disambiguate. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -280 lines) Patch
M gyp/tests.gypi View 3 chunks +4 lines, -4 lines 0 comments Download
D tests/DiscardableMemoryPool.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
A + tests/DiscardableMemoryPoolTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/GLInterfaceValidation.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
A + tests/GLInterfaceValidationTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/ToUnicode.cpp View 1 chunk +0 lines, -180 lines 0 comments Download
A + tests/ToUnicodeTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/Typeface.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
A + tests/TypefaceTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 9 months ago (2014-03-03 18:23:55 UTC) #1
rmistry
LGTM
6 years, 9 months ago (2014-03-03 18:24:42 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-03 18:25:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/185923002/1
6 years, 9 months ago (2014-03-03 18:25:59 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 19:23:33 UTC) #5
Message was sent while issue was closed.
Change committed as 13644

Powered by Google App Engine
This is Rietveld 408576698