chromecast/browser/cast_browser_main_parts.cc - Issue 1859213002: Move the thread hop for UMA user actions from content:: to base::.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/cast_browser_main_parts.cc

Issue 1859213002: Move the thread hop for UMA user actions from content:: to base::. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved call to SetRecordActionTaskRunner. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/browser/cast_browser_main_parts.cc

diff --git a/chromecast/browser/cast_browser_main_parts.cc b/chromecast/browser/cast_browser_main_parts.cc

index ed7cd4fe7a60f1d937f0768e7aa7eb8e1aa0eacf..7c3b69852c54d9699a7e66124e21f1f32fc57de1 100644

--- a/chromecast/browser/cast_browser_main_parts.cc

+++ b/chromecast/browser/cast_browser_main_parts.cc

@@ -443,8 +443,11 @@ void CastBrowserMainParts::PreMainMessageLoopRun() {

::media::InitializeMediaLibrary();

// Initializing metrics service and network delegates must happen after cast

- // service is intialized because CastMetricsServiceClient and

+ // service is initialized because CastMetricsServiceClient and

// CastNetworkDelegate may use components initialized by cast service.

+ // Set the thread on which to execute RecordAction.

Ilya Sherman 2016/04/15 22:16:05 nit: This comment seems rather redundant with the

beaudoin 2016/04/18 14:29:52 Done.

+ base::SetRecordActionTaskRunner(

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI));

cast_browser_process_->metrics_service_client()

->Initialize(cast_browser_process_->cast_service());

url_request_context_factory_->InitializeNetworkDelegates();

« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | components/metrics/BUILD.gn » ('j') | ios/chrome/browser/ios_chrome_main_parts.mm » ('J')