ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h - Issue 1859213002: Move the thread hop for UMA user actions from content:: to base::.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

Issue 1859213002: Move the thread hop for UMA user actions from content:: to base::. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing Chromecast (I hope!) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/metrics/cast_metrics_service_client.cc ('K') | « content/public/browser/user_metrics.h ('k') | ios/chrome/browser/metrics/ios_chrome_metrics_service_client.cc » ('j') | ios/chrome/browser/metrics/ios_chrome_metrics_service_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

diff --git a/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h b/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

index f0014a37532f004f69205efed2b958f6c0f5305e..fb453d284adccb64a02cfe1c0bde792c8b49ce19 100644

--- a/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

+++ b/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

@@ -68,9 +68,13 @@ class IOSChromeMetricsServiceClient

std::unique_ptr<metrics::MetricsLogUploader> CreateUploader(

const base::Callback<void(int)>& on_upload_complete) override;

base::TimeDelta GetStandardUploadInterval() override;

+ scoped_refptr<base::SingleThreadTaskRunner>

+ GetMainThreadTaskRunner() override;

base::string16 GetRegistryBackupKey() override;

void OnRendererProcessCrash() override;

+ // Returns the task runner for the main thread.

Ilya Sherman 2016/04/09 07:06:11 ?

beaudoin 2016/04/12 18:47:23 Done.

// web::GlobalWebStateObserver:

void WebStateDidStartLoading(web::WebState* web_state) override;

void WebStateDidStopLoading(web::WebState* web_state) override;