Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: content/browser/user_metrics.cc

Issue 1859213002: Move the thread hop for UMA user actions from content:: to base::. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/user_metrics.cc
diff --git a/content/browser/user_metrics.cc b/content/browser/user_metrics.cc
index 200c851ccb170a20d8e51486b7bcd286fc70ec98..175825c06948a1f9c3ea3d3848a3ec34e424a0f6 100644
--- a/content/browser/user_metrics.cc
+++ b/content/browser/user_metrics.cc
@@ -13,26 +13,10 @@
namespace content {
void RecordAction(const base::UserMetricsAction& action) {
- if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
- BrowserThread::PostTask(
- BrowserThread::UI,
- FROM_HERE,
- base::Bind(&RecordAction, action));
- return;
- }
-
base::RecordAction(action);
}
void RecordComputedAction(const std::string& action) {
- if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
- BrowserThread::PostTask(
- BrowserThread::UI,
- FROM_HERE,
- base::Bind(&RecordComputedAction, action));
- return;
- }
-
base::RecordComputedAction(action);
}
Ilya Sherman 2016/04/06 02:36:29 These methods seem like they could be removed enti
beaudoin 2016/04/06 15:06:13 Yes. Will do. Since it affects a lot more files I
Ilya Sherman 2016/04/06 21:48:48 Fair enough. Could you please file a bug and add
beaudoin 2016/04/07 18:12:34 Done. Filed as: crbug.com/601483
« components/metrics/metrics_service_client.h ('K') | « components/metrics/metrics_service_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698