components/metrics/metrics_service.cc - Issue 1859213002: Move the thread hop for UMA user actions from content:: to base::.

Unified Diff: components/metrics/metrics_service.cc

Issue 1859213002: Move the thread hop for UMA user actions from content:: to base::. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/metrics/user_metrics.cc ('K') | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | components/metrics/metrics_service_client.h » ('j') | components/metrics/metrics_service_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/metrics_service.cc

diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc

index c3ef7ec71d8dd9b69774d8c46a4a1ebb4196c61a..d1d2f66b5e2f3f90d542c0993ab11a7a7bf1b90b 100644

--- a/components/metrics/metrics_service.cc

+++ b/components/metrics/metrics_service.cc

@@ -301,6 +301,8 @@ MetricsService::MetricsService(MetricsStateManager* state_manager,

DCHECK(client_);

DCHECK(local_state_);

+ base::SetRecordActionTaskRunner(client_->GetUIThreadTaskRunner());

Ilya Sherman 2016/04/06 02:36:29 I think it makes sense to set this in the same pla

beaudoin 2016/04/06 15:06:13 It seems that a RecordAction is being called befor

Ilya Sherman 2016/04/06 21:48:48 Hmm, yeah, that sounds like a bug for sure -- ther

beaudoin 2016/04/07 18:12:34 Filed as: https://crbug.com/601482 I'll take a lo

// Set the install date if this is our first run.

int64_t install_date = local_state_->GetInt64(prefs::kInstallDate);

if (install_date == 0)