content/public/browser/user_metrics.h - Issue 1859213002: Move the thread hop for UMA user actions from content:: to base::.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/browser/user_metrics.h

Issue 1859213002: Move the thread hop for UMA user actions from content:: to base::. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/metrics/test_metrics_service_client.cc ('K') | « content/browser/user_metrics.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_PUBLIC_BROWSER_USER_METRICS_H_	5 #ifndef CONTENT_PUBLIC_BROWSER_USER_METRICS_H_

6 #define CONTENT_PUBLIC_BROWSER_USER_METRICS_H_	6 #define CONTENT_PUBLIC_BROWSER_USER_METRICS_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/callback.h"	10 #include "base/callback.h"

11 #include "base/metrics/user_metrics_action.h"	11 #include "base/metrics/user_metrics_action.h"

12 #include "content/common/content_export.h"	12 #include "content/common/content_export.h"

13	13

14 namespace content {	14 namespace content {

15	15

	16 // TODO(beaudoin): Get rid of these methods now that the base:: version does

	17 // thread hopping.
	Ilya Sherman 2016/04/07 18:21:54 Could you please also file a bug and add a referen Could you please also file a bug and add a reference to the bug here? beaudoin 2016/04/07 21:12:58 Done. Show quoted text On 2016/04/07 18:21:54, Ilya Sherman wrote: > Could you please also file a bug and add a reference to the bug here? Done.
16 // Wrappers around functions defined in base/metrics/user_metrics.h, refer to	18 // Wrappers around functions defined in base/metrics/user_metrics.h, refer to

17 // that header for full documentation. These wrappers can be called from any	19 // that header for full documentation. These wrappers can be called from any

18 // thread (they will post back to the UI thread to do the recording).	20 // thread (they will post back to the UI thread to do the recording).

19	21

20 CONTENT_EXPORT void RecordAction(const base::UserMetricsAction& action);	22 CONTENT_EXPORT void RecordAction(const base::UserMetricsAction& action);

21 CONTENT_EXPORT void RecordComputedAction(const std::string& action);	23 CONTENT_EXPORT void RecordComputedAction(const std::string& action);

22	24

23 } // namespace content	25 } // namespace content

24	26

25 #endif // CONTENT_PUBLIC_BROWSER_USER_METRICS_H_	27 #endif // CONTENT_PUBLIC_BROWSER_USER_METRICS_H_

OLD	NEW