Move the thread hop for UMA user actions from content:: to base::.

base/metrics/user_metrics.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/user_metrics.h"
 
 #include <stddef.h>
 
 #include <vector>
 
+#include "base/bind.h"
 #include "base/lazy_instance.h"
+#include "base/location.h"
 #include "base/macros.h"
 #include "base/threading/thread_checker.h"
 
 namespace base {
 namespace {
 
-// A helper class for tracking callbacks and ensuring thread-safety.
-class Callbacks {
- public:
-  Callbacks() {}
-
-  // Records the |action|.
-  void Record(const std::string& action) {
-    DCHECK(thread_checker_.CalledOnValidThread());
-    for (size_t i = 0; i < callbacks_.size(); ++i) {
-      callbacks_[i].Run(action);
-    }
-  }
-
-  // Adds |callback| to the list of |callbacks_|.
-  void AddCallback(const ActionCallback& callback) {
-    DCHECK(thread_checker_.CalledOnValidThread());
-    callbacks_.push_back(callback);
-  }
-
-  // Removes the first instance of |callback| from the list of |callbacks_|, if
-  // there is one.
-  void RemoveCallback(const ActionCallback& callback) {
-    DCHECK(thread_checker_.CalledOnValidThread());
-    for (size_t i = 0; i < callbacks_.size(); ++i) {
-      if (callbacks_[i].Equals(callback)) {
-        callbacks_.erase(callbacks_.begin() + i);
-        return;
-      }
-    }
-  }
-
- private:
-  base::ThreadChecker thread_checker_;
-  std::vector<ActionCallback> callbacks_;
-
-  DISALLOW_COPY_AND_ASSIGN(Callbacks);
-};
-
-base::LazyInstance<Callbacks> g_callbacks = LAZY_INSTANCE_INITIALIZER;
+base::LazyInstance<std::vector<ActionCallback>> g_callbacks =
+    LAZY_INSTANCE_INITIALIZER;
+base::LazyInstance<scoped_refptr<base::SingleThreadTaskRunner>> g_task_runner =
+    LAZY_INSTANCE_INITIALIZER;
 
 }  // namespace
 
 void RecordAction(const UserMetricsAction& action) {
-  g_callbacks.Get().Record(action.str_);
+  RecordComputedAction(action.str_);
 }
 
 void RecordComputedAction(const std::string& action) {
-  g_callbacks.Get().Record(action);
+  // Many tests do not register a task runner. This call shouldn't fail.
+  if(!g_task_runner.Get())
+    return;

[Ilya Sherman, 2016/04/07 18:21:53]

Please add a DCHECK within this if-stmt to verify that |g_callbacks| is empty in
this case.

[Ilya Sherman, 2016/04/07 18:21:53]

nit: Please leave a blank line after this if-stmt.

[beaudoin, 2016/04/07 21:12:58]

Done.

[beaudoin, 2016/04/07 21:12:58]

Done.

+  if (!g_task_runner.Get()->BelongsToCurrentThread()) {
+    g_task_runner.Get()->PostTask(FROM_HERE,
+        base::Bind(&RecordComputedAction, action));
+    return;
+  }

[Ilya Sherman, 2016/04/07 18:21:53]

nit: Please leave a blank line after this if-stmt.

[beaudoin, 2016/04/07 21:12:58]

Done.

+  const std::vector<ActionCallback>& callbacks = g_callbacks.Get();
+  for (size_t i = 0; i < callbacks.size(); ++i) {
+    callbacks[i].Run(action);
+  }
 }
 
 void AddActionCallback(const ActionCallback& callback) {
-  g_callbacks.Get().AddCallback(callback);
+  DCHECK(g_task_runner.Get() && g_task_runner.Get()->BelongsToCurrentThread());

[Ilya Sherman, 2016/04/07 18:21:53]

nit: Please write this as two DCHECKs, so that if either condition fails, it's
clear which one is failing.

[beaudoin, 2016/04/07 21:12:58]

Done.

+  g_callbacks.Get().push_back(callback);
 }
 
 void RemoveActionCallback(const ActionCallback& callback) {
-  g_callbacks.Get().RemoveCallback(callback);
+  DCHECK(g_task_runner.Get() && g_task_runner.Get()->BelongsToCurrentThread());

[Ilya Sherman, 2016/04/07 18:21:53]

nit: Ditto here

[beaudoin, 2016/04/07 21:12:58]

Done.

+  std::vector<ActionCallback>& callbacks = g_callbacks.Get();
+  for (size_t i = 0; i < callbacks.size(); ++i) {
+    if (callbacks[i].Equals(callback)) {
+      callbacks.erase(callbacks.begin() + i);
+      return;
+    }
+  }
+}
 
+void SetRecordActionTaskRunner(
+    scoped_refptr<base::SingleThreadTaskRunner> task_runner) {
+  DCHECK(!g_task_runner.Get());
+  g_task_runner.Get() = task_runner;
 }
 
 }  // namespace base