Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/browser_process_impl_unittest.cc

Issue 1859213002: Move the thread hop for UMA user actions from content:: to base::. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Initializing in content. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browser_process_impl.h" 5 #include "chrome/browser/browser_process_impl.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
11 #include "base/metrics/user_metrics.h"
11 #include "base/run_loop.h" 12 #include "base/run_loop.h"
12 #include "base/thread_task_runner_handle.h" 13 #include "base/thread_task_runner_handle.h"
13 #include "build/build_config.h" 14 #include "build/build_config.h"
14 #include "chrome/browser/profiles/profile_manager.h" 15 #include "chrome/browser/profiles/profile_manager.h"
15 #include "chrome/browser/ui/webui/ntp/ntp_resource_cache_factory.h" 16 #include "chrome/browser/ui/webui/ntp/ntp_resource_cache_factory.h"
16 #include "chrome/test/base/testing_profile.h" 17 #include "chrome/test/base/testing_profile.h"
17 #include "content/public/test/test_browser_thread.h" 18 #include "content/public/test/test_browser_thread.h"
18 #include "testing/gtest/include/gtest/gtest.h" 19 #include "testing/gtest/include/gtest/gtest.h"
19 20
20 class BrowserProcessImplTest : public ::testing::Test { 21 class BrowserProcessImplTest : public ::testing::Test {
21 protected: 22 protected:
22 BrowserProcessImplTest() 23 BrowserProcessImplTest()
23 : stashed_browser_process_(g_browser_process), 24 : stashed_browser_process_(g_browser_process),
24 loop_(base::MessageLoop::TYPE_UI), 25 loop_(base::MessageLoop::TYPE_UI),
25 ui_thread_(content::BrowserThread::UI, &loop_), 26 ui_thread_(content::BrowserThread::UI, &loop_),
26 file_thread_( 27 file_thread_(
27 new content::TestBrowserThread(content::BrowserThread::FILE)), 28 new content::TestBrowserThread(content::BrowserThread::FILE)),
28 io_thread_(new content::TestBrowserThread(content::BrowserThread::IO)), 29 io_thread_(new content::TestBrowserThread(content::BrowserThread::IO)),
29 command_line_(base::CommandLine::NO_PROGRAM), 30 command_line_(base::CommandLine::NO_PROGRAM),
30 browser_process_impl_( 31 browser_process_impl_(
31 new BrowserProcessImpl(base::ThreadTaskRunnerHandle::Get().get(), 32 new BrowserProcessImpl(base::ThreadTaskRunnerHandle::Get().get(),
32 command_line_)) { 33 command_line_)) {
34 base::SetRecordActionTaskRunner(loop_.task_runner());
33 browser_process_impl_->SetApplicationLocale("en"); 35 browser_process_impl_->SetApplicationLocale("en");
34 } 36 }
35 37
36 ~BrowserProcessImplTest() override { 38 ~BrowserProcessImplTest() override {
37 g_browser_process = nullptr; 39 g_browser_process = nullptr;
38 browser_process_impl_.reset(); 40 browser_process_impl_.reset();
39 // Restore the original browser process. 41 // Restore the original browser process.
40 g_browser_process = stashed_browser_process_; 42 g_browser_process = stashed_browser_process_;
41 } 43 }
42 44
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 // Pass ownership to the ProfileManager so that it manages the destruction. 95 // Pass ownership to the ProfileManager so that it manages the destruction.
94 browser_process_impl()->profile_manager()->RegisterTestingProfile( 96 browser_process_impl()->profile_manager()->RegisterTestingProfile(
95 profile.release(), false, false); 97 profile.release(), false, false);
96 98
97 // Tear down the BrowserProcessImpl and the threads. 99 // Tear down the BrowserProcessImpl and the threads.
98 browser_process_impl()->StartTearDown(); 100 browser_process_impl()->StartTearDown();
99 DestroySecondaryThreads(); 101 DestroySecondaryThreads();
100 browser_process_impl()->PostDestroyThreads(); 102 browser_process_impl()->PostDestroyThreads();
101 } 103 }
102 #endif // !defined(OS_ANDROID) && !defined(OS_CHROMEOS) 104 #endif // !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698