base/trace_event/heap_profiler_allocation_register.cc - Issue 1859143003: Handle zero-size allocations properly in heap profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/heap_profiler_allocation_register.cc

Issue 1859143003: Handle zero-size allocations properly in heap profiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/heap_profiler_allocation_register.cc

diff --git a/base/trace_event/heap_profiler_allocation_register.cc b/base/trace_event/heap_profiler_allocation_register.cc

index 9a846c5613c2ad4924c943a0cfb27e98d2a414fe..a0fc4be282dff9d4ff16cab045ee1056c6a64339 100644

--- a/base/trace_event/heap_profiler_allocation_register.cc

+++ b/base/trace_event/heap_profiler_allocation_register.cc

@@ -36,6 +36,8 @@ void AllocationRegister::Insert(void* address,

size_t size,

AllocationContext context) {

DCHECK(address != nullptr);

+ if (size == 0)

+ return;

CellIndex* idx_ptr = Lookup(address);

« no previous file with comments | « no previous file | base/trace_event/heap_profiler_allocation_register_unittest.cc » ('j') | no next file with comments »