Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1859133002: <webview> Clarify allowtransparency documentation. (Closed)

Created:
4 years, 8 months ago by avallee
Modified:
4 years, 8 months ago
Reviewers:
Fady Samuel, paulmeyer
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<webview> Clarify allowtransparency documentation. The docs are not in line with what I've seen. allowtransparency=[anything] is valid and will enable the feature. Additionally, there could be confusion about what it does. It allows the embedder to show through the guest, it does not disable transparency within the guests' content. BUG= Committed: https://crrev.com/926fb0be22514172bf02aecbebd70e72ae3eeaaa Cr-Commit-Position: refs/heads/master@{#385220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/common/extensions/docs/templates/intros/webview_tag.html View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
avallee
4 years, 8 months ago (2016-04-05 15:54:29 UTC) #2
paulmeyer
LGTM
4 years, 8 months ago (2016-04-05 16:01:15 UTC) #3
Fady Samuel
lgtm
4 years, 8 months ago (2016-04-05 16:53:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859133002/1
4 years, 8 months ago (2016-04-05 17:56:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 18:03:34 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:06:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/926fb0be22514172bf02aecbebd70e72ae3eeaaa
Cr-Commit-Position: refs/heads/master@{#385220}

Powered by Google App Engine
This is Rietveld 408576698