Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1859063003: [serializer] make snapshot reproducible. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
ulan
CC:
ulan, Hannes Payer (out of office), v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] make snapshot reproducible. R=ulan@chromium.org BUG=v8:4886 LOG=N Committed: https://crrev.com/6a604c8142521f79e24ce3ed0f8db62ccdfdb9ea Cr-Commit-Position: refs/heads/master@{#35266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/heap/heap.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/snapshot/mksnapshot.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot/startup-serializer.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 8 months ago (2016-04-05 13:03:49 UTC) #1
ulan
lgtm
4 years, 8 months ago (2016-04-05 14:05:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859063003/1
4 years, 8 months ago (2016-04-05 14:08:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 14:33:42 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 14:34:38 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6a604c8142521f79e24ce3ed0f8db62ccdfdb9ea
Cr-Commit-Position: refs/heads/master@{#35266}

Powered by Google App Engine
This is Rietveld 408576698