Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1859043005: Attempt to fix a crash in the GPU process while determining the max H.264 resolution which can be s… (Closed)

Created:
4 years, 8 months ago by ananta
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to fix a crash in the GPU process while determining the max H.264 resolution which can be supported Based on the crash dumps, it looks a number of legacy AMD drivers and some Intel second generation drivers have trouble handling resolutions larger than 1920 x 1088 and end up crashing while trying to create the video device for the same. The fix being tried is to maintain a list of such GPU's based on vendor id and treat them as legacy drivers which can support a max of 1920 x 1088. The AMD list is borrowed from mozilla. It is plausible that this list might need to grow. BUG=600512 Committed: https://crrev.com/cbd40b90c00447a2622fb35b948042104b3a1362 Cr-Commit-Position: refs/heads/master@{#385545}

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -0 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator_win.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator_win.cc View 3 chunks +107 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
ananta
4 years, 8 months ago (2016-04-06 01:18:18 UTC) #2
ananta
The TRACE_EVENT calls in the IsLegacyWindow revealed the following. This is in a debug chrome ...
4 years, 8 months ago (2016-04-06 01:20:13 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 8 months ago (2016-04-06 01:58:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859043005/20001
4 years, 8 months ago (2016-04-06 02:25:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/127874) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, ...
4 years, 8 months ago (2016-04-06 07:21:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859043005/20001
4 years, 8 months ago (2016-04-06 18:42:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 20:24:29 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 20:26:45 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cbd40b90c00447a2622fb35b948042104b3a1362
Cr-Commit-Position: refs/heads/master@{#385545}

Powered by Google App Engine
This is Rietveld 408576698