Issue 185903002: HashTraits<RawPtr> uses 'nullptr'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185903002: HashTraits<RawPtr> uses 'nullptr' (Closed)

Created:
6 years, 9 months ago by Mikhail

Modified:
6 years, 9 months ago

Reviewers:
tkent, haraken

CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium, Mads Ager (chromium), Erik Corry, tkent

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

HashTraits<RawPtr> uses 'nullptr' It is now agreed in blink that 'nullptr' is used to represent a null value for smart pointers. This patch makes HashTraits<RawPtr> use 'nullptr_t' as 'EmptyValueType' making it consistent with HashTraits<RefPtr> and HashTraits<OwnPtr>. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168520

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	Source/wtf/HashTraits.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/185903002/1

6 years, 9 months ago (2014-03-04 00:06:49 UTC) #3

Message was sent while issue was closed.

Change committed as 168520

Expand Messages | Collapse Messages