Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: tools/perf/core/stacktrace_unittest.py

Issue 1859013002: Copy cdb.exe into telemetry_chrome_test's isolate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-windows-stack-symbolization
Patch Set: Improve detection of whether to copy files thanks to dpranke@. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/core/stacktrace_unittest.py
diff --git a/tools/perf/core/stacktrace_unittest.py b/tools/perf/core/stacktrace_unittest.py
index 7d63db1280e45deefe3507a9d8ffeb637bca2830..2e8805679586277bca0e6fbc606b01a7a0664692 100644
--- a/tools/perf/core/stacktrace_unittest.py
+++ b/tools/perf/core/stacktrace_unittest.py
@@ -11,8 +11,8 @@ class TabStackTraceTest(tab_test_case.TabTestCase):
# TODO(dyen): For now this doesn't work on Android but continue to
# expand this.
- # TODO(kbr): this test doesn't work on the Windows Swarming bots
- # yet. http://crbug.com/561763
+ # TODO(kbr): currently failing on Windows because the symbolized
+ # stack trace format is unexpected. http://crbug.com/561763
@decorators.Enabled('mac', 'linux')
# Stack traces do not currently work on 10.6, but they are also being
# disabled shortly so just disable it for now.
@@ -24,9 +24,7 @@ class TabStackTraceTest(tab_test_case.TabTestCase):
self.assertIn('Thread 0 (crashed)', '\n'.join(e.stack_trace))
# Stack traces aren't working on Android yet.
- # TODO(kbr): this test doesn't work on the Windows Swarming bots
- # yet. http://crbug.com/561763
- @decorators.Enabled('mac', 'linux')
+ @decorators.Enabled('mac', 'linux', 'win')
@decorators.Disabled('snowleopard')
def testCrashSymbols(self):
try:

Powered by Google App Engine
This is Rietveld 408576698