Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3747)

Unified Diff: chrome/chrome_tests.gypi

Issue 1859013002: Copy cdb.exe into telemetry_chrome_test's isolate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-windows-stack-symbolization
Patch Set: Improve detection of whether to copy files thanks to dpranke@. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index 4bed8695c13930caeadcddb214d197327f4a83bf..4a33c97b8f7872926d14add3ca5e186cd404279f 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -3265,6 +3265,12 @@
'../third_party/crashpad/crashpad/tools/tools.gyp:crashpad_database_util',
],
}],
+ ['OS=="win"', {
+ 'dependencies': [
+ # TODO(kbr): port this dependency to GN.
+ 'copy_cdb_to_output',
+ ],
+ }],
],
},
{
@@ -3421,6 +3427,34 @@
},
],
'conditions': [
+ ['OS=="win"', {
+ 'targets': [
+ {
+ # TODO(kbr): port this target to GN.
+ 'target_name': 'copy_cdb_to_output',
+ 'type': 'none',
+ 'actions': [
+ {
+ 'action_name': 'copy_cdb',
+ 'inputs': [
+ '<(DEPTH)/build/win/copy_cdb_to_output.py',
+ ],
+ 'outputs': [
+ '<(PRODUCT_DIR)/cdb/cdb.exe',
+ '<(PRODUCT_DIR)/cdb/dbgeng.dll',
+ '<(PRODUCT_DIR)/cdb/dbghelp.dll',
+ '<(PRODUCT_DIR)/cdb/dbgmodel.dll',
+ ],
+ 'action': ['python',
+ '<(DEPTH)/build/win/copy_cdb_to_output.py',
+ '<(PRODUCT_DIR)/cdb',
+ '<(target_arch)'],
+ 'message': 'Copying cdb and deps to <(PRODUCT_DIR)/cdb',
+ },
+ ],
+ },
+ ],
+ }],
['archive_gpu_tests==1', {
'targets': [
{

Powered by Google App Engine
This is Rietveld 408576698