Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6775)

Unified Diff: chrome/chrome_tests.gypi

Issue 1859013002: Copy cdb.exe into telemetry_chrome_test's isolate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-windows-stack-symbolization
Patch Set: Addressed review feedback from scottmg and maruel. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index 38a00b8bd29851a2b38614ae83eff2b4e59c1646..bbc0496586e2c6f501a78c1e06d42ce8bbfc0623 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -3259,7 +3259,8 @@
}],
['OS=="mac" or OS=="win"', {
'dependencies': [
- # TODO(kbr): port this dependency to GN.
+ # TODO(kbr): port these dependencies to GN.
+ 'copy_cdb_to_output',
'../third_party/crashpad/crashpad/tools/tools.gyp:crashpad_database_util',
],
}],
@@ -3419,6 +3420,34 @@
},
],
'conditions': [
+ ['OS=="win"', {
+ 'targets': [
+ {
+ # TODO(kbr): port this target to GN.
+ 'target_name': 'copy_cdb_to_output',
+ 'type': 'none',
+ 'actions': [
+ {
+ 'action_name': 'copy_cdb',
+ 'inputs': [
+ '<(DEPTH)/build/win/copy_cdb_to_output.py',
+ ],
+ 'outputs': [
+ '<(PRODUCT_DIR)/cdb.exe',
+ '<(PRODUCT_DIR)/dbgeng.dll',
+ '<(PRODUCT_DIR)/dbghelp.dll',
+ '<(PRODUCT_DIR)/dbgmodel.dll',
+ ],
+ 'action': ['python',
+ '<(DEPTH)/build/win/copy_cdb_to_output.py',
+ '<(PRODUCT_DIR)',
+ '<(target_arch)'],
+ 'message': 'Copying cdb and dependencies to <(PRODUCT_DIR)',
+ },
+ ],
+ },
+ ],
+ }],
['archive_gpu_tests==1', {
'targets': [
{

Powered by Google App Engine
This is Rietveld 408576698