Blob support for IDB [Blink]

Source/modules/indexeddb/IDBAny.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 19 matching lines @@
 #include "modules/indexeddb/IDBKey.h"
 #include "modules/indexeddb/IDBKeyPath.h"
 #include "platform/SharedBuffer.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/RefPtr.h"
 #include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
+class BlobInfo;
 class DOMStringList;
 class IDBCursor;
 class IDBCursorWithValue;
 class IDBDatabase;
 class IDBFactory;
 class IDBIndex;
 class IDBKeyPath;
 class IDBObjectStore;
 class IDBTransaction;
 
 class IDBAny : public RefCounted<IDBAny> {
 public:
     static PassRefPtr<IDBAny> createUndefined();
     static PassRefPtr<IDBAny> createNull();
     static PassRefPtr<IDBAny> createString(const String&);
     template<typename T>
     static PassRefPtr<IDBAny> create(T* idbObject)
     {
         return adoptRef(new IDBAny(idbObject));
     }
     template<typename T>
     static PassRefPtr<IDBAny> create(const T& idbObject)
     {
         return adoptRef(new IDBAny(idbObject));
     }
+    static PassRefPtr<IDBAny> create(PassRefPtr<SharedBuffer> value, const Vector<BlobInfo>* blobInfo)
+    {
+        return adoptRef(new IDBAny(value, blobInfo));
+    }
     template<typename T>
     static PassRefPtr<IDBAny> create(PassRefPtr<T> idbObject)
     {
         return adoptRef(new IDBAny(idbObject));
     }
     static PassRefPtr<IDBAny> create(int64_t value)
     {
         return adoptRef(new IDBAny(value));
     }
-    static PassRefPtr<IDBAny> create(PassRefPtr<SharedBuffer> value, PassRefPtr<IDBKey> key, const IDBKeyPath& keyPath)
+    static PassRefPtr<IDBAny> create(PassRefPtr<SharedBuffer> value, const Vector<BlobInfo>* blobInfo, PassRefPtr<IDBKey> key, const IDBKeyPath& keyPath)
     {
-        return adoptRef(new IDBAny(value, key, keyPath));
+        return adoptRef(new IDBAny(value, blobInfo, key, keyPath));
     }
     ~IDBAny();
 
     enum Type {
         UndefinedType = 0,
         NullType,
         DOMStringListType,
         IDBCursorType,
         IDBCursorWithValueType,
         IDBDatabaseType,
@@ skipping 13 matching lines @@
     // Use type() to figure out which one of these you're allowed to call.
     DOMStringList* domStringList();
     IDBCursor* idbCursor();
     IDBCursorWithValue* idbCursorWithValue();
     IDBDatabase* idbDatabase();
     IDBFactory* idbFactory();
     IDBIndex* idbIndex();
     IDBObjectStore* idbObjectStore();
     IDBTransaction* idbTransaction();
     SharedBuffer* buffer();
+    const Vector<BlobInfo>* blobInfo() const;
     int64_t integer();
     const String& string();
     IDBKey* key();
     const IDBKeyPath& keyPath() const;
 
 private:
     explicit IDBAny(Type);
     explicit IDBAny(PassRefPtr<DOMStringList>);
     explicit IDBAny(PassRefPtr<IDBCursor>);
     explicit IDBAny(PassRefPtr<IDBDatabase>);
     explicit IDBAny(PassRefPtr<IDBFactory>);
     explicit IDBAny(PassRefPtr<IDBIndex>);
     explicit IDBAny(PassRefPtr<IDBObjectStore>);
     explicit IDBAny(PassRefPtr<IDBTransaction>);
     explicit IDBAny(PassRefPtr<IDBKey>);
     explicit IDBAny(const IDBKeyPath&);
     explicit IDBAny(const String&);
-    explicit IDBAny(PassRefPtr<SharedBuffer>);
-    explicit IDBAny(PassRefPtr<SharedBuffer>, PassRefPtr<IDBKey>, const IDBKeyPath&);
+    explicit IDBAny(PassRefPtr<SharedBuffer>, const Vector<BlobInfo>*);

[jsbell, 2013/12/20 19:13:54]

Nit: Don't need explicit on multi-parameter constructors.

(Sorry, existing ones are my fault.)

[ericu, 2014/02/12 19:12:55]

Done.

+    explicit IDBAny(PassRefPtr<SharedBuffer>, const Vector<BlobInfo>*, PassRefPtr<IDBKey>, const IDBKeyPath&);
     explicit IDBAny(int64_t);
 
     const Type m_type;
 
-    // Only one of the following should ever be in use at any given time.
+    // Only one of the following should ever be in use at any given time, except that BufferType uses two and BufferKeyAndKeyPathType uses four.

[jsbell, 2013/12/20 19:13:54]

Thanks for the comment update.

     const RefPtr<DOMStringList> m_domStringList;
     const RefPtr<IDBCursor> m_idbCursor;
     const RefPtr<IDBDatabase> m_idbDatabase;
     const RefPtr<IDBFactory> m_idbFactory;
     const RefPtr<IDBIndex> m_idbIndex;
     const RefPtr<IDBObjectStore> m_idbObjectStore;
     const RefPtr<IDBTransaction> m_idbTransaction;
     const RefPtr<IDBKey> m_idbKey;
     const IDBKeyPath m_idbKeyPath;
     const RefPtr<SharedBuffer> m_buffer;
+    const Vector<BlobInfo>* m_blobInfo;
     const String m_string;
     const int64_t m_integer;
 };
 
 } // namespace WebCore
 
 #endif // IDBAny_h