Blob support for IDB [Blink]

Source/bindings/v8/SerializedScriptValue.h

 /*
  * Copyright (C) 2009, 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef SerializedScriptValue_h
 #define SerializedScriptValue_h
 
+#include "bindings/v8/BlobInfo.h"
 #include "bindings/v8/ScriptValue.h"
 
 #include "wtf/ThreadSafeRefCounted.h"
 #include <v8.h>
 
 namespace WTF {
 
 class ArrayBuffer;
 class ArrayBufferContents;
 
 }
 
 namespace WebCore {
 
 class MessagePort;
 
 typedef Vector<RefPtr<MessagePort>, 1> MessagePortArray;
 typedef Vector<RefPtr<WTF::ArrayBuffer>, 1> ArrayBufferArray;
 
 class SerializedScriptValue : public ThreadSafeRefCounted<SerializedScriptValue> {
 public:
     virtual ~SerializedScriptValue();
 
     // If a serialization error occurs (e.g., cyclic input value) this
     // function returns an empty representation, schedules a V8 exception to
     // be thrown using v8::ThrowException(), and sets |didThrow|. In this case
     // the caller must not invoke any V8 operations until control returns to
     // V8. When serialization is successful, |didThrow| is false.
-    static PassRefPtr<SerializedScriptValue> create(v8::Handle<v8::Value>, MessagePortArray*, ArrayBufferArray*, bool& didThrow, v8::Isolate*);
+    static PassRefPtr<SerializedScriptValue> create(v8::Handle<v8::Value>, MessagePortArray*, ArrayBufferArray*, Vector<BlobInfo>*, bool& didThrow, v8::Isolate*);

[jsbell, 2013/09/12 22:52:17]

For symmetry, a with MessagePortArray and ArrayBufferArray, how about typedef
Vector<BlobInfo> BlobInfoArray ?

Within SSV at least, the use pattern is pretty much exactly the same.

[ericu, 2013/11/20 23:06:08]

Huh.  That won't compile, despite being identical.  Something to do with
overloaded methods wanting to know the full definition of BlobInfo?  I'm going
to put that on the low-priority list.

+    static PassRefPtr<SerializedScriptValue> create(v8::Handle<v8::Value>, Vector<BlobInfo>*, bool&);
+    static PassRefPtr<SerializedScriptValue> create(v8::Handle<v8::Value>, MessagePortArray*, ArrayBufferArray*, bool&, v8::Isolate*);
     static PassRefPtr<SerializedScriptValue> create(v8::Handle<v8::Value>, v8::Isolate*);
     static PassRefPtr<SerializedScriptValue> createFromWire(const String&);
     static PassRefPtr<SerializedScriptValue> createFromWireBytes(const Vector<uint8_t>&);
     static PassRefPtr<SerializedScriptValue> create(const String&);
     static PassRefPtr<SerializedScriptValue> create(const String&, v8::Isolate*);
     static PassRefPtr<SerializedScriptValue> create();
 
     // Never throws exceptions.
     static PassRefPtr<SerializedScriptValue> createAndSwallowExceptions(v8::Handle<v8::Value>, v8::Isolate*);
 
     static PassRefPtr<SerializedScriptValue> nullValue();
     static PassRefPtr<SerializedScriptValue> nullValue(v8::Isolate*);
     static PassRefPtr<SerializedScriptValue> undefinedValue();
     static PassRefPtr<SerializedScriptValue> undefinedValue(v8::Isolate*);
     static PassRefPtr<SerializedScriptValue> booleanValue(bool);
     static PassRefPtr<SerializedScriptValue> booleanValue(bool, v8::Isolate*);
     static PassRefPtr<SerializedScriptValue> numberValue(double);
     static PassRefPtr<SerializedScriptValue> numberValue(double, v8::Isolate*);
 
     static uint32_t wireFormatVersion();
 
     PassRefPtr<SerializedScriptValue> release();
 
     String toWireString() const { return m_data; }
     void toWireBytes(Vector<char>&) const;
 
     // Deserializes the value (in the current context). Returns a null value in
     // case of failure.
     v8::Handle<v8::Value> deserialize(MessagePortArray* = 0);
-    v8::Handle<v8::Value> deserialize(v8::Isolate*, MessagePortArray* = 0);
+    v8::Handle<v8::Value> deserialize(const Vector<BlobInfo>*);
+    v8::Handle<v8::Value> deserialize(v8::Isolate*, MessagePortArray* = 0, const
+        Vector<BlobInfo>* = 0);
 
     ScriptValue deserializeForInspector(ScriptState*);
 
-    const Vector<String>& blobURLs() const { return m_blobURLs; }
+    const Vector<BlobInfo>* blobInfo() const { return m_blobInfo; }

[jsbell, 2013/09/12 22:52:17]

So far as I can tell, this is only used in a DCHECK in the new code? 
Can we remove m_blobInfo entirely, so just the ephemeral Reader/Writer has it as
a member?

[ericu, 2013/11/20 23:06:08]

Yup!  Done.

 
     // Informs the V8 about external memory allocated and owned by this object. Large values should contribute
     // to GC counters to eventually trigger a GC, otherwise flood of postMessage() can cause OOM.
     // Ok to invoke multiple times (only adds memory once).
     // The memory registration is revoked automatically in destructor.
     void registerMemoryAllocatedWithCurrentScriptContext();
 
 private:
     enum StringDataMode {
         StringValue,
         WireData
     };
     enum ExceptionPolicy {
         ThrowExceptions,
         DoNotThrowExceptions
     };
     typedef Vector<WTF::ArrayBufferContents, 1> ArrayBufferContentsArray;
 
     SerializedScriptValue();
-    SerializedScriptValue(v8::Handle<v8::Value>, MessagePortArray*, ArrayBufferArray*, bool& didThrow, v8::Isolate*, ExceptionPolicy = ThrowExceptions);
+    SerializedScriptValue(v8::Handle<v8::Value>, MessagePortArray*, ArrayBufferArray*, Vector<BlobInfo>*, bool& didThrow, v8::Isolate*, ExceptionPolicy = ThrowExceptions);
     explicit SerializedScriptValue(const String& wireData);
 
     static PassOwnPtr<ArrayBufferContentsArray> transferArrayBuffers(ArrayBufferArray&, bool& didThrow, v8::Isolate*);
 
     String m_data;
     OwnPtr<ArrayBufferContentsArray> m_arrayBufferContentsArray;
-    Vector<String> m_blobURLs;
+    Vector<BlobInfo> *m_blobInfo;
     intptr_t m_externallyAllocatedMemory;
 };
 
 } // namespace WebCore
 
 #endif // SerializedScriptValue_h