LayoutTests/storage/indexeddb/blob-valid-before-commit.html - Issue 18590006: Blob support for IDB [Blink]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/storage/indexeddb/blob-valid-before-commit.html

Issue 18590006: Blob support for IDB [Blink] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix expectations too. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/storage/indexeddb/blob-valid-after-deletion.html ('K') | « LayoutTests/storage/indexeddb/blob-valid-after-deletion-expected.txt ('k') | LayoutTests/storage/indexeddb/blob-valid-before-commit-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../resources/js-test.js"></script>

	4 <script src="resources/shared.js"></script>

	5 </head>

	6 <body>

	7 <iframe id="frame0"></iframe>

	8 <iframe id="frame1"></iframe>

	9 <iframe id="frame2"></iframe>

	10 <script>

	11

	12 description("Confirm that blobs can be read back before their records are commit ted.");

	13

	14 indexedDBTest(prepareDatabase);

	15 function prepareDatabase()

	16 {

	17 db = event.target.result;

	18 event.target.transaction.onabort = unexpectedAbortCallback;

	19 evalAndLog("store = db.createObjectStore('store')");

	20 blobAContent = "Blob A content";

	21 blobBContent = "Blob B content";

	22 var blobA = new Blob([blobAContent], {"type" : "text\/plain"});

	23 var blobB = new Blob([blobBContent], {"type" : "text\/plain"});

	24 key = "key"

	25 value = { a0: blobA, a1: blobA, b0: blobB };

	26 evalAndLog("store.put(value, key)");

	27 evalAndLog("request = store.get(key)");

	28 request.onsuccess = didRead;

	29 }

	30

	31 function didRead()

	32 {

	33 record = request.result;

	34 urlA0 = URL.createObjectURL(record.a0);

	35 urlA1 = URL.createObjectURL(record.a1);

	36 urlB = URL.createObjectURL(record.b0);

	37 document.getElementById('frame0').src = urlA0;

	38 document.getElementById('frame0').onload = verification;

	39 document.getElementById('frame1').src = urlA1;

	40 document.getElementById('frame1').onload = verification;

	41 document.getElementById('frame2').src = urlB;

	42 document.getElementById('frame2').onload = verification;

	43 }

	44

	45 var loadCount = 0;

	46 function verification()

	47 {

	48 if (++loadCount < 3)

	49 return;

	50 delete record;

	51 record = null;
	cmumford 2014/06/04 21:01:19 Do you need to set record to null? Do you need to set record to null? jsbell 2014/06/04 21:56:26 Ditto (pointed out/missed/harmless/useless) Show quoted text On 2014/06/04 21:01:19, cmumford wrote: > Do you need to set record to null? Ditto (pointed out/missed/harmless/useless) ericu 2014/06/06 22:57:00 Done. Show quoted text On 2014/06/04 21:56:26, jsbell wrote: > On 2014/06/04 21:01:19, cmumford wrote: > > Do you need to set record to null? > > Ditto (pointed out/missed/harmless/useless) Done.
	52 URL.revokeObjectURL(urlA0);

	53 URL.revokeObjectURL(urlA1);

	54 URL.revokeObjectURL(urlB);

	55 shouldBe("document.getElementById('frame0').contentDocument.body.innerText",

	56 "blobAContent");

	57 shouldBe("document.getElementById('frame1').contentDocument.body.innerText",

	58 "blobAContent");

	59 shouldBe("document.getElementById('frame2').contentDocument.body.innerText",

	60 "blobBContent");

	61 finishJSTest();

	62 }

	63

	64 </script>

	65 </body>

	66 </html>

	67

OLD	NEW