LayoutTests/storage/indexeddb/blob-delete-objectstore-db.html - Issue 18590006: Blob support for IDB [Blink]

Side by Side Diff: LayoutTests/storage/indexeddb/blob-delete-objectstore-db.html

Issue 18590006: Blob support for IDB [Blink] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebasing issue? Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/storage/indexeddb/blob-basics-metadata-expected.txt ('K') | « LayoutTests/storage/indexeddb/blob-basics-metadata-expected.txt ('k') | LayoutTests/storage/indexeddb/blob-delete-objectstore-db-expected.txt » ('j') | LayoutTests/storage/indexeddb/blob-valid-after-deletion.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../resources/js-test.js"></script>

	4 <script src="resources/shared.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8

	9 description("Test deleting an object store and a database containing blobs.");
	jsbell 2014/05/29 00:40:06 Since this test doesn't have any shouldXXXX() asse Since this test doesn't have any shouldXXXX() assertions, maybe add a note that it's just watching for crashes. ericu 2014/06/02 22:18:47 Done. Show quoted text On 2014/05/29 00:40:06, jsbell wrote: > Since this test doesn't have any shouldXXXX() assertions, maybe add a note that > it's just watching for crashes. Done.
	10

	11 indexedDBTest(prepareDatabase, reopen, {version: 1});

	12 function prepareDatabase()

	13 {

	14 db = event.target.result;

	15 event.target.transaction.onabort = unexpectedAbortCallback;

	16 evalAndLog("store0 = db.createObjectStore('store0')");

	17 evalAndLog("store1 = db.createObjectStore('store1')");

	18 blobAContent = "First blob content";

	19 blobA = new Blob([blobAContent], {"type" : "text\/plain"});
	jsbell 2014/05/29 00:40:06 No need to escape the forward slash here (and belo No need to escape the forward slash here (and below) ericu 2014/06/02 22:18:47 Done. Show quoted text On 2014/05/29 00:40:06, jsbell wrote: > No need to escape the forward slash here (and below) Done.
	20 key = "blob key";

	21 evalAndLog("store0.put(blobA, key)");

	22 delete blobA;
	jsbell 2014/05/29 00:40:06 This is unusual; it's unclear why you'd write this This is unusual; it's unclear why you'd write this with the delete operator, other than to "scope" the variable while still exposing it to the evalAndLog()-family of helpers. We don't do that anywhere else in our tests. The variable isn't referenced elsewhere, either, so it's not even worth doing `blobA = null` or `blobA = undefined`. It makes it read like an attempt to release the blob, but that won't happen without e.g. an explicit gc() call, and then the idiomatic form in tests would be `blobA = null; gc();` ericu 2014/06/02 22:18:47 Fixed; I'd misremembered how delete worked. As it Show quoted text On 2014/05/29 00:40:06, jsbell wrote: > This is unusual; it's unclear why you'd write this with the delete operator, > other than to "scope" the variable while still exposing it to the > evalAndLog()-family of helpers. We don't do that anywhere else in our tests. > > The variable isn't referenced elsewhere, either, so it's not even worth doing > `blobA = null` or `blobA = undefined`. It makes it read like an attempt to > release the blob, but that won't happen without e.g. an explicit gc() call, and > then the idiomatic form in tests would be `blobA = null; gc();` Fixed; I'd misremembered how delete worked. As it turns out, there's no reason we even need to drop the reference here.
	23 }

	24

	25 function reopen()

	26 {

	27 evalAndLog("db.close()");

	28 debug("");

	29 debug("reopen():");

	30 request = indexedDB.open(dbname, 2);

	31 request.onupgradeneeded = deleteObjectStore;

	32 request.onsuccess = unexpectedSuccessCallback;

	33 request.onerror = unexpectedErrorCallback;

	34 request.onblocked = unexpectedBlockedCallback;

	35 }

	36

	37 function deleteObjectStore(e)

	38 {

	39 debug("");

	40 debug("deleteObjectStore():");

	41 db = e.target.result;

	42 evalAndLog("db.deleteObjectStore('store0')");

	43 request.onsuccess = didDeleteObjectStore;

	44 }

	45

	46 function didDeleteObjectStore()

	47 {

	48 debug("");

	49 debug("didDeleteObjectStore()");

	50 blobBContent = "Second blob content";

	51 evalAndLog("trans = db.transaction('store1', 'readwrite')");

	52 evalAndLog("store1 = trans.objectStore('store1')");

	53 blobB = new Blob([blobBContent], {"type" : "text\/plain"});

	54 evalAndLog("store1.put(blobB, key)");

	55 delete blobB;

	56 trans.oncomplete = deleteDatabase;

	57 }

	58

	59 function deleteDatabase()

	60 {

	61 evalAndLog("db.close()");

	62 evalAndLog("request = indexedDB.deleteDatabase(dbname)");

	63 request.onerror = unexpectedErrorCallback;

	64 request.onsuccess = reportSuccess;

	65 }

	66

	67 function reportSuccess()

	68 {

	69 debug("Database deleted.");

	70 finishJSTest();

	71 }

	72 </script>

	73 </body>

	74 </html>

	75

OLD	NEW