Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 18590: Irregexp: Missing initialization of field. (Closed)

Created:
11 years, 11 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

A field might be incorrectly set, causing registers to be pushed and popped instead of just cleared on backtrack - or, worse, the other way around!

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/jsregexp.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Quick review for a quick bugfix.
11 years, 11 months ago (2009-01-26 14:53:54 UTC) #1
Mads Ager (chromium)
11 years, 11 months ago (2009-01-26 15:25:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698