ipc/ipc_platform_file.h - Issue 1858973002: ipc: Rename GetFileHandleForProcess->GetPlatformFileForTransit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_platform_file.h

Issue 1858973002: ipc: Rename GetFileHandleForProcess->GetPlatformFileForTransit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp16_ipc_pfft_implementation

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_platform_file.h

diff --git a/ipc/ipc_platform_file.h b/ipc/ipc_platform_file.h

index 045655a15769120838a16792b142aa3c2b9da7ef..4e718caee1f7fdeee4fc412f9089fce2452113ee 100644

--- a/ipc/ipc_platform_file.h

+++ b/ipc/ipc_platform_file.h

@@ -55,10 +55,10 @@ inline base::File PlatformFileForTransitToFile(

#endif

}

-// Returns a file handle equivalent to |file| that can be used in |process|.

-IPC_EXPORT PlatformFileForTransit GetFileHandleForProcess(

+// Creates a new handle that can be passed through IPC. The result must be

+// passed to the IPC stack, or else it will leak.

Tom Sepez 2016/04/05 17:45:06 nit: "passed to the IPC layer as part of a message

erikchen 2016/04/05 19:25:33 Done.

+IPC_EXPORT PlatformFileForTransit GetPlatformFileForTransit(

base::PlatformFile file,

- base::ProcessHandle process,

bool close_source_handle);

// Returns a file handle equivalent to |file| that can be used in |process|.

« no previous file with comments | « content/public/test/mock_render_process_host.cc ('k') | ipc/ipc_platform_file.cc » ('j') | no next file with comments »