Rename printing::ClipBox to PdfRectangle.

Rename printing::ClipBox to PdfRectangle.

Also reorder the struct members to be in the same order as defined by
the PDF spec.

Committed: https://crrev.com/09649faffc63fef55e75db5cdfb8685f3799895c
Cr-Commit-Position: refs/heads/master@{#386911}

[Lei Zhang, 2016-04-05 00:34:24]

thestig@chromium.org changed reviewers:
+ krb@chromium.org

[Lei Zhang, 2016-04-05 00:34:25]

I hope you didn't have as much trouble remembering the ordering for ClipBox vs
rectangles in PDFs.

... o O (left, bottom, top, right)

[Kevin Bailey, 2016-04-05 13:17:13]

On 2016/04/05 00:34:25, Lei Zhang wrote:
> I hope you didn't have as much trouble remembering the ordering for ClipBox vs
> rectangles in PDFs.
> 
> ... o O (left, bottom, top, right)

My problem wasn't so much what they referred to as "where is the origin, and
which way is up?" (which is backwards in these files from standard computer
graphics.)

Obviously, you can name these things whatever you want, but I'm curious why
this change is better. I instantly knew what 'ClipBox' was. 'PdfRectangle' ?
It sounds like something you might define 'ClipBox' in terms of, but 'ClipBox'
describes the true purpose.

Plus, I vaguely recall that 'ClipBox' matches the library's documentation?

[Lei Zhang, 2016-04-06 01:34:07]

On 2016/04/05 13:17:13, Kevin Bailey wrote:
> On 2016/04/05 00:34:25, Lei Zhang wrote:
> > I hope you didn't have as much trouble remembering the ordering for ClipBox
vs
> > rectangles in PDFs.
> > 
> > ... o O (left, bottom, top, right)
> 
> Obviously, you can name these things whatever you want, but I'm curious why
> this change is better. I instantly knew what 'ClipBox' was. 'PdfRectangle' ?
> It sounds like something you might define 'ClipBox' in terms of, but 'ClipBox'
> describes the true purpose.
>
> Plus, I vaguely recall that 'ClipBox' matches the library's documentation?

"ClipBox" originally came out of https://chromereviews.googleplex.com/3861025 -
it's not a real term in the PDF world. Thew various boxes in PDFs include the
media box and crop box. e.g. FPDFPage_GetMediaBox() and friends.

I wanted to name it a PdfRectangle because the PDF spec defines a rectangle in
section 3.8.4 as the 4 coordinates in that specific order.
FPDFPage_GetMediaBox() also has the parameters in the same order.

[Kevin Bailey, 2016-04-06 13:17:45]

On 2016/04/06 01:34:07, Lei Zhang wrote:
> On 2016/04/05 13:17:13, Kevin Bailey wrote:
> > On 2016/04/05 00:34:25, Lei Zhang wrote:
> > > I hope you didn't have as much trouble remembering the ordering for
ClipBox
> vs
> > > rectangles in PDFs.
> > > 
> > > ... o O (left, bottom, top, right)
> > 
> > Obviously, you can name these things whatever you want, but I'm curious why
> > this change is better. I instantly knew what 'ClipBox' was. 'PdfRectangle' ?
> > It sounds like something you might define 'ClipBox' in terms of, but
'ClipBox'
> > describes the true purpose.
> >
> > Plus, I vaguely recall that 'ClipBox' matches the library's documentation?
> 
> "ClipBox" originally came out of https://chromereviews.googleplex.com/3861025
-
> it's not a real term in the PDF world. Thew various boxes in PDFs include the
> media box and crop box. e.g. FPDFPage_GetMediaBox() and friends.
> 
> I wanted to name it a PdfRectangle because the PDF spec defines a rectangle in
> section 3.8.4 as the 4 coordinates in that specific order.
> FPDFPage_GetMediaBox() also has the parameters in the same order.

lgtm

[Lei Zhang, 2016-04-12 22:15:11]

thestig@chromium.org changed reviewers:
+ raymes@chromium.org

[Lei Zhang, 2016-04-12 22:15:11]

raymes: Can you help stamp this?

[raymes, 2016-04-12 22:27:10]

lgtm (though I'm only an OWNER of pdf/, like you :)

https://codereview.chromium.org/1858963002/diff/1/printing/pdf_transform.h
File printing/pdf_transform.h (right):

https://codereview.chromium.org/1858963002/diff/1/printing/pdf_transform.h#ne...
printing/pdf_transform.h:64: PRINTING_EXPORT void ScalePdfRectangle(double
scale_factor, PdfRectangle* rect);
How come you changed the name of this function but not others?

[Lei Zhang, 2016-04-13 01:00:17]

https://codereview.chromium.org/1858963002/diff/1/printing/pdf_transform.h
File printing/pdf_transform.h (right):

https://codereview.chromium.org/1858963002/diff/1/printing/pdf_transform.h#ne...
printing/pdf_transform.h:64: PRINTING_EXPORT void ScalePdfRectangle(double
scale_factor, PdfRectangle* rect);
On 2016/04/12 22:27:10, raymes wrote:
> How come you changed the name of this function but not others?

This felt generic enough to apply to any PdfRectangle. Other functions in this
file did not.

[Lei Zhang, 2016-04-13 01:44:45]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-04-13 01:44:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858963002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858963002/1

[commit-bot: I haz the power, 2016-04-13 03:26:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-13 03:28:52]

Description was changed from

==========
Rename printing::ClipBox to PdfRectangle.

Also reorder the struct members to be in the same order as defined by
the PDF spec.
==========

to

==========
Rename printing::ClipBox to PdfRectangle.

Also reorder the struct members to be in the same order as defined by
the PDF spec.

Committed: https://crrev.com/09649faffc63fef55e75db5cdfb8685f3799895c
Cr-Commit-Position: refs/heads/master@{#386911}
==========

[commit-bot: I haz the power, 2016-04-13 03:28:53]

Patchset 1 (id:??) landed as
https://crrev.com/09649faffc63fef55e75db5cdfb8685f3799895c
Cr-Commit-Position: refs/heads/master@{#386911}