Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1858953002: Ignore paint containment when considering fixed-position table-row containers (Closed)

Created:
4 years, 8 months ago by leviw_travelin_and_unemployed
Modified:
4 years, 8 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore paint containment when considering fixed-position table-row containers Use the same logic as we use for transform-related properties, namely: don't consider things that aren't LayoutBlocks. TEST=fast/css/containment/paint-contained-tablerow-with-fixed-children.html BUG=599627 R=eae@chromium.org Committed: https://crrev.com/2372314a1313820af17c53f2f5b32bfba65362bc Cr-Commit-Position: refs/heads/master@{#385082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/containment/paint-contained-tablerow-with-fixed-children.html View 1 chunk +7 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/css/containment/paint-contained-tablerow-with-fixed-children-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
leviw_travelin_and_unemployed
4 years, 8 months ago (2016-04-05 00:45:24 UTC) #2
eae
LGTM
4 years, 8 months ago (2016-04-05 00:48:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858953002/1
4 years, 8 months ago (2016-04-05 00:49:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 01:53:35 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 01:55:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2372314a1313820af17c53f2f5b32bfba65362bc
Cr-Commit-Position: refs/heads/master@{#385082}

Powered by Google App Engine
This is Rietveld 408576698