Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1858943002: Remove runtime flags for sloppy mode block scoping features (Closed)

Created:
4 years, 8 months ago by adamk
Modified:
4 years, 8 months ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove runtime flags for sloppy mode block scoping features These were all on by default in M49 without complaint. R=littledan@chromium.org Committed: https://crrev.com/a0a8ecd078a24f67a1d4c58568b452446301915b Cr-Commit-Position: refs/heads/master@{#35342}

Patch Set 1 #

Patch Set 2 : Fix GCC build #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -3013 lines) Patch
M src/bootstrapper.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M src/messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 1 2 14 chunks +11 lines, -91 lines 0 comments Download
M src/parsing/parser-base.h View 7 chunks +1 line, -28 lines 0 comments Download
M src/parsing/preparser.cc View 1 8 chunks +7 lines, -35 lines 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-asm-validator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 51 chunks +55 lines, -211 lines 0 comments Download
M test/cctest/test-typing-reset.cc View 1 chunk +0 lines, -1 line 0 comments Download
D test/message/const-decl-no-init-sloppy.js View 1 chunk +0 lines, -9 lines 0 comments Download
M test/message/let-lexical-name-in-array-prohibited.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/let-lexical-name-in-object-prohibited.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/let-lexical-name-prohibited.js View 1 chunk +1 line, -1 line 0 comments Download
D test/message/no-legacy-const.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/message/no-legacy-const.out View 1 chunk +0 lines, -5 lines 0 comments Download
D test/message/no-legacy-const-2.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/message/no-legacy-const-2.out View 1 chunk +0 lines, -5 lines 0 comments Download
D test/message/no-legacy-const-3.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/message/no-legacy-const-3.out View 1 chunk +0 lines, -5 lines 0 comments Download
A + test/mjsunit/es6/block-conflicts-sloppy.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-const-assign-sloppy.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/es6/block-early-errors.js View 1 chunk +0 lines, -54 lines 0 comments Download
A + test/mjsunit/es6/block-eval-var-over-let.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-for-sloppy.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-leave-sloppy.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/block-let-contextual-sloppy.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-let-crankshaft-sloppy.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/block-let-declaration-sloppy.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-let-semantics-sloppy.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/es6/block-non-strict-errors.js View 1 chunk +0 lines, -42 lines 0 comments Download
M test/mjsunit/es6/block-scope-class.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-scoping-sloppy.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/block-scoping-top-level-sloppy.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/block-sloppy-function.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/es6/class-computed-property-names-super.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/class-property-name-eval-arguments.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/classes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/classes-derived-return-type.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/completion.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-4482.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/spread-call-new-class.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/spread-call-super-property.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/super.js View 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/harmony/block-conflicts-sloppy.js View 1 chunk +0 lines, -179 lines 0 comments Download
D test/mjsunit/harmony/block-const-assign-sloppy.js View 1 chunk +0 lines, -158 lines 0 comments Download
D test/mjsunit/harmony/block-eval-var-over-let.js View 1 chunk +0 lines, -143 lines 0 comments Download
D test/mjsunit/harmony/block-for-sloppy.js View 1 chunk +0 lines, -201 lines 0 comments Download
D test/mjsunit/harmony/block-leave-sloppy.js View 1 chunk +0 lines, -224 lines 0 comments Download
D test/mjsunit/harmony/block-let-crankshaft-sloppy.js View 1 chunk +0 lines, -483 lines 0 comments Download
D test/mjsunit/harmony/block-let-declaration-sloppy.js View 1 chunk +0 lines, -174 lines 0 comments Download
D test/mjsunit/harmony/block-let-semantics-sloppy.js View 1 chunk +0 lines, -193 lines 0 comments Download
D test/mjsunit/harmony/block-scoping-sloppy.js View 1 chunk +0 lines, -309 lines 0 comments Download
D test/mjsunit/harmony/block-scoping-top-level-sloppy.js View 1 chunk +0 lines, -34 lines 0 comments Download
D test/mjsunit/harmony/block-sloppy-function.js View 1 chunk +0 lines, -301 lines 0 comments Download
M test/mjsunit/harmony/do-expressions.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/regress/regress-4482.js View 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/regress/regress-3926.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-4693.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-520029.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-536751.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-542099.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-542100.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-451770.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-constructor-return.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-call.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-declaration.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-default-constructor.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-expression.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-extends.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-name.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-prototype.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-scoping.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-semicolon.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-super.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
adamk
4 years, 8 months ago (2016-04-04 23:44:09 UTC) #1
Dan Ehrenberg
lgtm
4 years, 8 months ago (2016-04-07 22:31:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858943002/1
4 years, 8 months ago (2016-04-07 23:57:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858943002/20001
4 years, 8 months ago (2016-04-07 23:58:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/3969) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-08 00:00:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858943002/40001
4 years, 8 months ago (2016-04-08 00:03:27 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-08 00:29:45 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 00:30:25 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a0a8ecd078a24f67a1d4c58568b452446301915b
Cr-Commit-Position: refs/heads/master@{#35342}

Powered by Google App Engine
This is Rietveld 408576698