Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1858903002: MD Settings: Move settings-animated-pages CSS to HTML (Closed)

Created:
4 years, 8 months ago by michaelpg
Modified:
4 years, 8 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Move settings-animated-pages CSS to HTML BUG=600588 R=dpapad@chromium.org Committed: https://crrev.com/1bf849aaf8ed65dd27cfdf8411b8b874d8e37af5 Cr-Commit-Position: refs/heads/master@{#385088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
D chrome/browser/resources/settings/settings_page/settings_animated_pages.css View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_animated_pages.html View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
michaelpg
same deal, PTAL
4 years, 8 months ago (2016-04-04 23:02:17 UTC) #1
dpapad
lgtm
4 years, 8 months ago (2016-04-04 23:52:03 UTC) #2
dpapad
Nit regarding crbug.com/425627: This top-level bug is very generic and now has about 120 comments ...
4 years, 8 months ago (2016-04-04 23:56:10 UTC) #3
michaelpg
On 2016/04/04 23:56:10, dpapad wrote: > Nit regarding crbug.com/425627: This top-level bug is very generic ...
4 years, 8 months ago (2016-04-05 00:52:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858903002/1
4 years, 8 months ago (2016-04-05 00:53:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 02:20:05 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 02:21:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bf849aaf8ed65dd27cfdf8411b8b874d8e37af5
Cr-Commit-Position: refs/heads/master@{#385088}

Powered by Google App Engine
This is Rietveld 408576698