Remove CAPS

Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky

Committed: https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f
Cr-Commit-Position: refs/heads/master@{#389907}

Committed: https://crrev.com/98a2ebb14d32b05cf091b6498a720c4dc84038ec
Cr-Commit-Position: refs/heads/master@{#389945}

[scottmg, 2016-04-05 21:22:13]

Description was changed from

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service.exe's and also a content_shell_crash_service.exe.

BUG=
==========

to

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

BUG=
==========

[scottmg, 2016-04-05 21:24:46]

scottmg@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-05 22:40:00]

lgtm assuming we get buy-in from jochen@ and phajdan.jr@ on
https://codereview.chromium.org/1862773003/ first (and that lands first).

[scottmg, 2016-04-26 21:06:32]

Forgot to land this after https://crbug.com/601762 got sorted out. Going to try
to now.

[scottmg, 2016-04-26 21:23:42]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-04-26 21:23:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1858883004/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-04-26 21:24:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858883004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858883004/20001

[commit-bot: I haz the power, 2016-04-26 21:32:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 21:32:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scottmg, 2016-04-26 21:34:47]

scottmg@chromium.org changed reviewers:
+ sky@chromium.org

[scottmg, 2016-04-26 21:34:48]

+sky for OWNERS. Apparently I can't delete something I OWNER if I'm also
deleting the OWNERS file (?)

[Dirk Pranke, 2016-04-26 21:40:16]

On 2016/04/26 21:34:48, scottmg wrote:
> +sky for OWNERS. Apparently I can't delete something I OWNER if I'm also
> deleting the OWNERS file (?)

Yeah, the owners check is stupid and just looks at the files locally in the repo
post-patch.

[scottmg, 2016-04-26 21:41:23]

Description was changed from

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

BUG=
==========

to

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky
==========

[sky, 2016-04-26 21:51:01]

LGTM

[scottmg, 2016-04-26 21:51:28]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-04-26 21:52:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858883004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858883004/20001

[commit-bot: I haz the power, 2016-04-26 21:59:36]

Description was changed from

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky
==========

to

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky
==========

[commit-bot: I haz the power, 2016-04-26 21:59:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-26 22:01:58]

Description was changed from

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky
==========

to

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky

Committed: https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f
Cr-Commit-Position: refs/heads/master@{#389907}
==========

[commit-bot: I haz the power, 2016-04-26 22:01:59]

Patchset 2 (id:??) landed as
https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f
Cr-Commit-Position: refs/heads/master@{#389907}

[Charlie Reis, 2016-04-26 22:28:09]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1921973006/ by creis@chromium.org.

The reason for reverting is: Caused a compile error on Win:
https://build.chromium.org/p/chromium/builders/Win/builds/42776

ninja: error: '../../chrome/tools/crash_service/main.cc', needed by
'obj/chrome/tools/crash_service/crash_service.main.obj', missing and no known
rule to make it
.

[scottmg, 2016-04-26 22:34:54]

Description was changed from

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky

Committed: https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f
Cr-Commit-Position: refs/heads/master@{#389907}
==========

to

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky

Committed: https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f
Cr-Commit-Position: refs/heads/master@{#389907}
==========

[scottmg, 2016-04-26 22:38:14]

On 2016/04/26 22:28:09, Charlie Reis wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1921973006/ by mailto:creis@chromium.org.
> 
> The reason for reverting is: Caused a compile error on Win:
> https://build.chromium.org/p/chromium/builders/Win/builds/42776
> 
> ninja: error: '../../chrome/tools/crash_service/main.cc', needed by
> 'obj/chrome/tools/crash_service/crash_service.main.obj', missing and no known
> rule to make it
> .

Looks like we don't have win gyp coverage on the CQ any more :( I think ps#3
should work for gyp too.

[Dirk Pranke, 2016-04-26 22:40:24]

On 2016/04/26 22:38:14, scottmg wrote:
> On 2016/04/26 22:28:09, Charlie Reis wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/1921973006/ by mailto:creis@chromium.org.
> > 
> > The reason for reverting is: Caused a compile error on Win:
> > https://build.chromium.org/p/chromium/builders/Win/builds/42776
> > 
> > ninja: error: '../../chrome/tools/crash_service/main.cc', needed by
> > 'obj/chrome/tools/crash_service/crash_service.main.obj', missing and no
known
> > rule to make it
> > .
> 
> Looks like we don't have win gyp coverage on the CQ any more :( I think ps#3
> should work for gyp too.

No, 32-bit win should still be on the CQ (win_chromium_rel_ng), but it doesn't
build 'all'.

[scottmg, 2016-04-26 22:44:12]

On 2016/04/26 22:40:24, Dirk Pranke wrote:
> On 2016/04/26 22:38:14, scottmg wrote:
> > On 2016/04/26 22:28:09, Charlie Reis wrote:
> > > A revert of this CL (patchset #2 id:20001) has been created in
> > > https://codereview.chromium.org/1921973006/ by mailto:creis@chromium.org.
> > > 
> > > The reason for reverting is: Caused a compile error on Win:
> > > https://build.chromium.org/p/chromium/builders/Win/builds/42776
> > > 
> > > ninja: error: '../../chrome/tools/crash_service/main.cc', needed by
> > > 'obj/chrome/tools/crash_service/crash_service.main.obj', missing and no
> known
> > > rule to make it
> > > .
> > 
> > Looks like we don't have win gyp coverage on the CQ any more :( I think ps#3
> > should work for gyp too.
> 
> No, 32-bit win should still be on the CQ (win_chromium_rel_ng), but it doesn't
> build 'all'.

Not really covered then since that's what
https://build.chromium.org/p/chromium/builders/Win builds. :)

OK. I tried gyp Release 'all' locally, so I'll try again now.

[scottmg, 2016-04-26 22:44:16]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-04-26 22:44:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1858883004/#ps40001
(title: "gyp")

[commit-bot: I haz the power, 2016-04-26 22:44:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858883004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858883004/40001

[commit-bot: I haz the power, 2016-04-26 23:51:35]

Description was changed from

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky

Committed: https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f
Cr-Commit-Position: refs/heads/master@{#389907}
==========

to

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky

Committed: https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f
Cr-Commit-Position: refs/heads/master@{#389907}
==========

[commit-bot: I haz the power, 2016-04-26 23:51:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-26 23:52:46]

Description was changed from

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky

Committed: https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f
Cr-Commit-Position: refs/heads/master@{#389907}
==========

to

==========
Remove CAPS

One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.

TBR=sky

Committed: https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f
Cr-Commit-Position: refs/heads/master@{#389907}

Committed: https://crrev.com/98a2ebb14d32b05cf091b6498a720c4dc84038ec
Cr-Commit-Position: refs/heads/master@{#389945}
==========

[commit-bot: I haz the power, 2016-04-26 23:52:48]

Patchset 3 (id:??) landed as
https://crrev.com/98a2ebb14d32b05cf091b6498a720c4dc84038ec
Cr-Commit-Position: refs/heads/master@{#389945}